Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: pkg/compiler/lib/src/ssa/interceptor_simplifier.dart

Issue 2814453005: Merge CommonElements and BackendHelpers! (Closed)
Patch Set: comments and re-merge, take two Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/interceptor_simplifier.dart
diff --git a/pkg/compiler/lib/src/ssa/interceptor_simplifier.dart b/pkg/compiler/lib/src/ssa/interceptor_simplifier.dart
index b6c6707f053a4a13b30a761c40e01575a17342b7..08c0d9a7f479eb9cb16f447641afca437c0329e0 100644
--- a/pkg/compiler/lib/src/ssa/interceptor_simplifier.dart
+++ b/pkg/compiler/lib/src/ssa/interceptor_simplifier.dart
@@ -2,11 +2,11 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+import '../common_elements.dart' show CommonElements;
import '../common/backend_api.dart' show BackendClasses;
import '../constants/constant_system.dart';
import '../constants/values.dart';
import '../elements/entities.dart';
-import '../js_backend/backend_helpers.dart';
import '../js_backend/interceptor_data.dart';
import '../types/types.dart';
import '../universe/selector.dart' show Selector;
@@ -38,13 +38,13 @@ class SsaSimplifyInterceptors extends HBaseVisitor
implements OptimizationPhase {
final String name = "SsaSimplifyInterceptors";
final ClosedWorld closedWorld;
- final BackendHelpers helpers;
final InterceptorData interceptorData;
+ final CommonElements _commonElements;
final ClassEntity enclosingClass;
HGraph graph;
- SsaSimplifyInterceptors(this.closedWorld, this.helpers, this.interceptorData,
- this.enclosingClass);
+ SsaSimplifyInterceptors(this.closedWorld, this._commonElements,
+ this.interceptorData, this.enclosingClass);
BackendClasses get backendClasses => closedWorld.backendClasses;
@@ -108,7 +108,8 @@ class SsaSimplifyInterceptors extends HBaseVisitor
// All intercepted classes extend `Interceptor`, so if the receiver can't be
// a class extending `Interceptor` then it can be called directly.
- return new TypeMask.nonNullSubclass(helpers.jsInterceptorClass, closedWorld)
+ return new TypeMask.nonNullSubclass(
+ _commonElements.jsInterceptorClass, closedWorld)
.isDisjoint(receiver.instructionType, closedWorld);
}
« no previous file with comments | « pkg/compiler/lib/src/ssa/graph_builder.dart ('k') | pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698