Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart

Issue 2814453005: Merge CommonElements and BackendHelpers! (Closed)
Patch Set: comments and re-merge, take two Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart b/pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart
index 9e4ace2034ee2c32dba146c7c875b677ce460714..9e74bc344e83c7de2256ab451e83789b44102185 100644
--- a/pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart
@@ -210,7 +210,7 @@ class ModelEmitter {
'callName': js.string(namer.callNameField)
}),
'cyclicThrow': backend.emitter
- .staticFunctionAccess(backend.helpers.cyclicThrowHelper),
+ .staticFunctionAccess(backend.commonElements.cyclicThrowHelper),
'outputContainsConstantList': program.outputContainsConstantList,
'embeddedGlobals': emitEmbeddedGlobals(program),
'readMetadataTypeFunction': readMetadataTypeFunction,
@@ -1025,7 +1025,7 @@ function parseFunctionDescriptor(proto, name, descriptor, typesOffset) {
};
} else {
// Parse the tear off information and generate compile handlers.
- // TODO(herhut): Share parser with instance methods.
+ // TODO(herhut): Share parser with instance methods.
function compileAllStubs(typesOffset) {
var funs;
var fun = compile(name, descriptor[0]);
@@ -1048,7 +1048,7 @@ function parseFunctionDescriptor(proto, name, descriptor, typesOffset) {
if (typeof reflectionInfo == "number") {
reflectionInfo = reflectionInfo + typesOffset;
}
- holder[descriptor[2]] =
+ holder[descriptor[2]] =
tearOff(funs, reflectionInfo, true, name, false);
}
if (pos < descriptor.length) {

Powered by Google App Engine
This is Rietveld 408576698