Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2814443005: Fix for summarization of generic function type aliases and support for resynthesizing. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for summarization of generic function type aliases and support for resynthesizing. This is based on your CL https://codereview.chromium.org/2808093004/ and includes fixes for summarization and resynthesis. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/29237 Committed: https://github.com/dart-lang/sdk/commit/f0ae30dca5ada7fc18d7b0c42fc05ff9aa3a64d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -44 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +21 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/handle.dart View 1 chunk +39 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +10 lines, -23 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/prelink.dart View 1 chunk +12 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 3 chunks +13 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_driver_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 2 chunks +43 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/element_text.dart View 1 chunk +18 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +44 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 2 chunks +62 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-11 01:31:41 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-11 13:36:26 UTC) #2
scheglov
3 years, 8 months ago (2017-04-11 14:07:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f0ae30dca5ada7fc18d7b0c42fc05ff9aa3a64d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698