Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: chrome/browser/android/vr_shell/ui_scene_unittest.cc

Issue 2814443004: Refactor VR math off of GVR types, onto gfx types where possible. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/ui_scene_unittest.cc
diff --git a/chrome/browser/android/vr_shell/ui_scene_unittest.cc b/chrome/browser/android/vr_shell/ui_scene_unittest.cc
index cfcc3d6ef9a4b708ded496bd5ebc3f302e18ac0b..128a7f1055cb47deedfec37a27cb0cc23afdc7fb 100644
--- a/chrome/browser/android/vr_shell/ui_scene_unittest.cc
+++ b/chrome/browser/android/vr_shell/ui_scene_unittest.cc
@@ -14,15 +14,16 @@
#include "chrome/browser/android/vr_shell/animation.h"
#include "chrome/browser/android/vr_shell/easing.h"
#include "chrome/browser/android/vr_shell/ui_elements.h"
-#include "chrome/browser/android/vr_shell/vr_math.h"
+#include "device/vr/vr_math.h"
+#include "device/vr/vr_types.h"
#include "testing/gtest/include/gtest/gtest.h"
#define TOLERANCE 0.0001
-#define EXPECT_VEC3F_NEAR(a, b) \
- EXPECT_NEAR(a.x, b.x, TOLERANCE); \
- EXPECT_NEAR(a.y, b.y, TOLERANCE); \
- EXPECT_NEAR(a.z, b.z, TOLERANCE);
+#define EXPECT_VEC3F_NEAR(a, b) \
+ EXPECT_NEAR(a.x(), b.x(), TOLERANCE); \
+ EXPECT_NEAR(a.y(), b.y(), TOLERANCE); \
+ EXPECT_NEAR(a.z(), b.z(), TOLERANCE);
namespace vr_shell {
@@ -123,14 +124,14 @@ TEST(UiScene, ParentTransformAppliesToChild) {
scene.AddUiElement(std::move(element));
const ContentRectangle* child = scene.GetUiElementById(1);
- const gvr::Vec3f origin({0, 0, 0});
- const gvr::Vec3f point({1, 0, 0});
+ const gfx::Vector3dF origin(0, 0, 0);
+ const gfx::Vector3dF point(1, 0, 0);
scene.UpdateTransforms(0);
- auto new_origin = MatrixVectorMul(child->TransformMatrix(), origin);
- auto new_point = MatrixVectorMul(child->TransformMatrix(), point);
- EXPECT_VEC3F_NEAR(gvr::Vec3f({6, 10, 0}), new_origin);
- EXPECT_VEC3F_NEAR(gvr::Vec3f({0, 10, 0}), new_point);
+ auto new_origin = vr::MatrixVectorMul(child->TransformMatrix(), origin);
+ auto new_point = vr::MatrixVectorMul(child->TransformMatrix(), point);
+ EXPECT_VEC3F_NEAR(gfx::Vector3dF(6, 10, 0), new_origin);
+ EXPECT_VEC3F_NEAR(gfx::Vector3dF(0, 10, 0), new_point);
}
TEST(UiScene, Opacity) {
@@ -274,22 +275,22 @@ TEST(UiScene, AddUiElementFromDictionary) {
EXPECT_EQ(element->copy_rect.width, 102);
EXPECT_EQ(element->copy_rect.height, 103);
- EXPECT_FLOAT_EQ(element->size.x, 200);
- EXPECT_FLOAT_EQ(element->size.y, 201);
- EXPECT_FLOAT_EQ(element->size.z, 1);
+ EXPECT_FLOAT_EQ(element->size.x(), 200);
+ EXPECT_FLOAT_EQ(element->size.y(), 201);
+ EXPECT_FLOAT_EQ(element->size.z(), 1);
- EXPECT_FLOAT_EQ(element->scale.x, 300);
- EXPECT_FLOAT_EQ(element->scale.y, 301);
- EXPECT_FLOAT_EQ(element->scale.z, 302);
+ EXPECT_FLOAT_EQ(element->scale.x(), 300);
+ EXPECT_FLOAT_EQ(element->scale.y(), 301);
+ EXPECT_FLOAT_EQ(element->scale.z(), 302);
EXPECT_FLOAT_EQ(element->rotation.x, 400);
EXPECT_FLOAT_EQ(element->rotation.y, 401);
EXPECT_FLOAT_EQ(element->rotation.z, 402);
EXPECT_FLOAT_EQ(element->rotation.angle, 403);
- EXPECT_FLOAT_EQ(element->translation.x, 500);
- EXPECT_FLOAT_EQ(element->translation.y, 501);
- EXPECT_FLOAT_EQ(element->translation.z, 502);
+ EXPECT_FLOAT_EQ(element->translation.x(), 500);
+ EXPECT_FLOAT_EQ(element->translation.y(), 501);
+ EXPECT_FLOAT_EQ(element->translation.z(), 502);
dict.Clear();
dict.SetInteger("id", 12);

Powered by Google App Engine
This is Rietveld 408576698