Fix a bug in TextInputManager::GetCompositionRangeInfo

content/browser/renderer_host/text_input_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/text_input_manager.h"
 
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
 #include "content/common/view_messages.h"
 #include "ui/gfx/geometry/rect.h"
@@ skipping 59 matching lines @@
     view = active_view_;
   return view ? &selection_region_map_.at(view) : nullptr;
 }
 
 const TextInputManager::CompositionRangeInfo*
 TextInputManager::GetCompositionRangeInfo(
     RenderWidgetHostViewBase* view) const {
   DCHECK(!view || IsRegistered(view));
   if (!view)
     view = active_view_;
-  return active_view_ ? &composition_range_info_map_.at(active_view_) : nullptr;

[EhsanK, 2017/04/10 14:50:29]

Right now we do not actually even use this method for a non-null
|view| (all the calls to the method use the default nullptr value for view).
That being said I am working on moving IME tracking to make use of focused frame
(instead of purely relying on TextInputState) and I guess I will be using this
method on focused view. That said, I can either remove |view| as an argument
here now and maybe add it back later, or just keep it as is for now. WDYT?

[Charlie Reis, 2017/04/10 18:31:21]

Let's go ahead and remove it for now, since it's easy to add back if you need it
later.

[EhsanK, 2017/04/10 18:37:10]

Acknowledged.

+  return view ? &composition_range_info_map_.at(view) : nullptr;
 }
 
 const TextInputManager::TextSelection* TextInputManager::GetTextSelection(
     RenderWidgetHostViewBase* view) const {
   DCHECK(!view || IsRegistered(view));
   if (!view)
     view = active_view_;
   return !!view ? &text_selection_map_.at(view) : nullptr;
 }
 
@@ skipping 255 matching lines @@
     if (pos >= text.length()) {
       LOG(WARNING) << "The text cannot cover range (selection range's starting "
                       "point exceeds text length).";
     } else {
       selected_text_.append(text.substr(pos, n));
     }
   }
 }
 
 }  // namespace content