MD Settings: Users: Focus dialog buttons on close

chrome/browser/resources/settings/people_page/lock_screen.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-lock-screen' allows the user to change how they unlock their
  * device.
  *
  * Example:
@@ skipping 189 matching lines @@
     if (this.shouldAskForPassword_(settings.getCurrentRoute())) {
       this.$.setupPin.close();
       this.$.passwordPrompt.open();
     }
   },
 
   /** @private */
   onPasswordClosed_: function() {
     if (!this.setModes_)
       settings.navigateTo(settings.Route.PEOPLE);
+    else
+      this.$$('#unlockType').focus();

[dpapad, 2017/04/13 17:56:32]

Nit (optional): The new ID seems redundant, since the element can already by
uniquely identified with $$('paper-radio-group').

[stevenjb, 2017/04/13 18:02:10]

For now... This page may grow over time. *shrug*

   },
 
   /** @private */
   onPinSetupDone_: function() {
     this.$.setupPin.close();
   },
 
+  /** @private */
+  onSetupPinClosed_: function() {
+    this.$$('#setupPinLink').focus();

[dpapad, 2017/04/13 17:56:32]

Nit (optional): Same here, $$('link[is=action-link]') would also locate the same
element.

[stevenjb, 2017/04/13 18:02:10]

Ditto.

+  },
+
   /**
    * Returns true if the setup pin section should be shown.
    * @param {!string} selectedUnlockType The current unlock type. Used to let
    *     Polymer know about the dependency.
    * @private
    */
   showConfigurePinButton_: function(selectedUnlockType) {
     return selectedUnlockType === LockScreenUnlockType.PIN_PASSWORD;
   },
 
@@ skipping 86 matching lines @@
   /**
    * @param {boolean} easyUnlockEnabled
    * @param {boolean} proximityDetectionAllowed
    * @private
    */
   getShowEasyUnlockToggle_: function(
       easyUnlockEnabled, proximityDetectionAllowed) {
     return easyUnlockEnabled && proximityDetectionAllowed;
   },
 });