Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: tools/win/ShowThreadNames/ReadMe.txt

Issue 2814383003: Format ReadMe.txt for ShowThreadNames tool (Closed)
Patch Set: Update readme.txt Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/win/ShowThreadNames/ReadMe.txt
diff --git a/tools/win/ShowThreadNames/ReadMe.txt b/tools/win/ShowThreadNames/ReadMe.txt
index 63aa0cf8243d034afe0c19250ec420c9286e7dfd..c4bf66aba3fec1e3567773bde8e76224c26aace4 100644
--- a/tools/win/ShowThreadNames/ReadMe.txt
+++ b/tools/win/ShowThreadNames/ReadMe.txt
@@ -2,10 +2,9 @@
This tool is designed to test the usage of the SetThreadDescription WinAPI in
Chrome. In Chrome, the SetThreadDescription API has been enabled to set thread
names. However, since there is no tool support to retrieve thread names set by
-GetThreadDescription, we will still rely on SetNameInternal function in
-platform_thread_win.cc to set thread names. Despite this, we need a tool to
-demo the SetThreadDescription API works, even without the debugger to be
-present.
+GetThreadDescription, we'll still rely on SetNameInternal function in
+platform_thread_win.cc to set thread names. Despite this, we need a tool to demo
+the SetThreadDescription API works, even without the debugger to be present.
The problem setting can be referred to
https://bugs.chromium.org/p/chromium/issues/detail?id=684203
@@ -22,11 +21,11 @@ later ones.
[How to use it]
Please download the three files (.cc, .sln, .vcxproj) and compile the code in
-Visual Studio. Run "ShowThreadNames.exe" either from the build directory or
-from Visual Studio. No parameters are needed. This tool allows interaction
-with users. Once launched, it will show "Please enter the process Id, or
-"quit" to end the program :" on the terminal. Simply type in the ID of any
-Chrome process you are interested in, and you will get output like below:
+Visual Studio. Run "ShowThreadNames.exe" either from the build directory or from
+Visual Studio. No parameters are needed. This tool allows interaction with the
+user. Once launched, it will show "Please enter the process Id, or "quit" to
+end the program :" on the terminal. Simply type in the ID of any Chrome process
+you are interested in, and you will get output like below:
thread_ID thread_name
12116
@@ -56,6 +55,6 @@ thread_ID thread_name
8216 TaskSchedulerServiceThread
11088 VideoCaptureThread
-The threads have been sorted by their names. Note that some threads have
-no names in this example. If checking them using Visual Studio debugger, it
-is found that they are ntdll.dll!WorkerThreads.
+The threads are sorted by their names. Note that some threads have no names in
+this example. If checking them using Visual Studio debugger, it is found that
+they are ntdll.dll!WorkerThreads.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698