Index: tools/win/ShowThreadNames/ReadMe.txt |
diff --git a/tools/win/ShowThreadNames/ReadMe.txt b/tools/win/ShowThreadNames/ReadMe.txt |
index 63aa0cf8243d034afe0c19250ec420c9286e7dfd..4888f42baf76b637252aad2d3fbf88a298bcef1d 100644 |
--- a/tools/win/ShowThreadNames/ReadMe.txt |
+++ b/tools/win/ShowThreadNames/ReadMe.txt |
@@ -2,17 +2,16 @@ |
This tool is designed to test the usage of the SetThreadDescription WinAPI in |
Chrome. In Chrome, the SetThreadDescription API has been enabled to set thread |
names. However, since there is no tool support to retrieve thread names set by |
-GetThreadDescription, we will still rely on SetNameInternal function in |
-platform_thread_win.cc to set thread names. Despite this, we need a tool to |
-demo the SetThreadDescription API works, even without the debugger to be |
-present. |
+GetThreadDescription, we'll still rely on SetNameInternal function in |
+platform_thread_win.cc to set thread names. Despite this, we need a tool to demo |
+the SetThreadDescription API works, even without the debugger to be present. |
The problem setting can be referred to |
https://bugs.chromium.org/p/chromium/issues/detail?id=684203 |
This tool incorporates the GetThreadDescription API trying to get names of all |
threads in a process specified by its ID. If the thread names have been set by |
-SetThreadDescription API call like in Chrome, all thread ID/name pairs are |
+SetThreadDescription API call like in Chrome, all thread ID-name pairs are |
brucedawson
2017/04/14 18:05:59
This actually wrong, I think. You should have eith
chengx
2017/04/14 18:33:22
Done. Thanks!
|
returned. |
[Requirement] |
@@ -22,11 +21,11 @@ later ones. |
[How to use it] |
Please download the three files (.cc, .sln, .vcxproj) and compile the code in |
-Visual Studio. Run "ShowThreadNames.exe" either from the build directory or |
-from Visual Studio. No parameters are needed. This tool allows interaction |
-with users. Once launched, it will show "Please enter the process Id, or |
-"quit" to end the program :" on the terminal. Simply type in the ID of any |
-Chrome process you are interested in, and you will get output like below: |
+Visual Studio. Run "ShowThreadNames.exe" either from the build directory or from |
+Visual Studio. No parameters are needed. This tool allows interaction with the |
+users. Once launched, it will show "Please enter the process Id, or "quit" to |
brucedawson
2017/04/14 18:05:59
"the user" reads better than "the users"
chengx
2017/04/14 18:33:22
Done.
|
+end the program :" on the terminal. Simply type in the ID of any Chrome process |
+you are interested in, and you will get output like below: |
thread_ID thread_name |
12116 |
@@ -56,6 +55,6 @@ thread_ID thread_name |
8216 TaskSchedulerServiceThread |
11088 VideoCaptureThread |
-The threads have been sorted by their names. Note that some threads have |
-no names in this example. If checking them using Visual Studio debugger, it |
-is found that they are ntdll.dll!WorkerThreads. |
+The threads are sorted by their names. Note that some threads have no names in |
+this example. If checking them using Visual Studio debugger, it is found that |
+they are ntdll.dll!WorkerThreads. |