Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2814343002: Fire a click event even when a clicked text node is removed in mouseup (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/EventHandler.cpp
diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp
index 14fa616ebe39f6a16d080a8b765ce95fe9d601d0..ebed3dd37ac57a26cb98263d7fc741c2ca9bf60f 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.cpp
+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp
@@ -949,6 +949,9 @@ WebInputEventResult EventHandler::handleMouseReleaseEvent(
HitTestRequest request(hitType);
MouseEventWithHitTestResults mev =
EventHandlingUtil::performMouseEventHitTest(m_frame, request, mouseEvent);
+ Node* releaseNode = (mev.innerNode() && mev.innerNode()->isTextNode())
+ ? FlatTreeTraversal::Parent(*mev.innerNode())
+ : mev.innerNode();
LocalFrame* subframe =
m_capturingMouseEventsNode.get()
? subframeForTargetNode(m_capturingMouseEventsNode.get())
@@ -981,7 +984,7 @@ WebInputEventResult EventHandler::handleMouseReleaseEvent(
mev.event(), Vector<WebMouseEvent>());
WebInputEventResult clickEventResult =
- m_mouseEventManager->dispatchMouseClickIfNeeded(mev);
+ m_mouseEventManager_->dispatchMouseClickIfNeeded(mev, releaseNode);
m_scrollManager->clearResizeScrollableArea(false);

Powered by Google App Engine
This is Rietveld 408576698