Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: tests/standalone/io/raw_synchronous_socket_test.dart

Issue 2814283002: Added missing sync_socket_unsupported.cc and fixed issues in test which were causing analysis errors (Closed)
Patch Set: Added missing definition in sync_socket_unsupported.cc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/sync_socket_unsupported.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/raw_synchronous_socket_test.dart
diff --git a/tests/standalone/io/raw_synchronous_socket_test.dart b/tests/standalone/io/raw_synchronous_socket_test.dart
index 28236b987183d7eaa23904936d7b60798302f922..44d9cbc90463bbf12730dc0902cbdfcfe11df182 100644
--- a/tests/standalone/io/raw_synchronous_socket_test.dart
+++ b/tests/standalone/io/raw_synchronous_socket_test.dart
@@ -20,8 +20,6 @@ void testArguments() {
() => RawSynchronousSocket.connectSync(LOOPBACK_IP_V4_STRING, 65536));
Expect.throws(
() => RawSynchronousSocket.connectSync(LOOPBACK_IP_V4_STRING, -1));
- Expect.throws(() =>
- RawSynchronousSocket.connectSync(LOOPBACK_IP_V4_STRING, 0, backlog: -1));
}
// The connection attempt happens on the main Dart thread and the OS timeout can
@@ -189,7 +187,7 @@ Future echoServer(var sendPort) async {
}, onDone: () {
// Let the client know we're shutting down then kill the isolate.
sendPort.send(null);
- kill();
+ Isolate.current.kill();
});
});
}
« no previous file with comments | « runtime/bin/sync_socket_unsupported.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698