Issue 2814283002: Added missing sync_socket_unsupported.cc and fixed issues in test which were causing analysis errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2814283002: Added missing sync_socket_unsupported.cc and fixed issues in test which were causing analysis errors (Closed)

Created:
3 years, 8 months ago by bkonyi

Modified:
3 years, 8 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Added missing sync_socket_unsupported.cc and fixed issues in test which were causing analysis errors BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/7549bc6b485ef3b819f3cf52c1a4688afa17f4ea

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -3 lines)			Patch
	A	runtime/bin/sync_socket_unsupported.cc	View	1	1 chunk	+84 lines, -0 lines	0 comments	Download
	M	tests/standalone/io/raw_synchronous_socket_test.dart	View		2 chunks	+1 line, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

bkonyi

3 years, 8 months ago (2017-04-12 22:13:21 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
7549bc6b485ef3b819f3cf52c1a4688afa17f4ea (presubmit successful).