Makes -init and -setType: available in CollectionViewItem

ios/chrome/browser/ui/collection_view/cells/collection_view_item.h

Index: ios/chrome/browser/ui/collection_view/cells/collection_view_item.h
diff --git a/ios/chrome/browser/ui/collection_view/cells/collection_view_item.h b/ios/chrome/browser/ui/collection_view/cells/collection_view_item.h
index 78be71e4899e9ad81da799879a5aa1fe75460f85..9c0aaa0292905d77d1678ea0bf2483a31f86c7e0 100644
--- a/ios/chrome/browser/ui/collection_view/cells/collection_view_item.h
+++ b/ios/chrome/browser/ui/collection_view/cells/collection_view_item.h
@@ -21,7 +21,7 @@
 @property(nonatomic, assign) Class cellClass;
 
 - (instancetype)initWithType:(NSInteger)type NS_DESIGNATED_INITIALIZER;
-- (instancetype)init NS_UNAVAILABLE;
+- (instancetype)init;

[lpromero, 2017/04/13 21:42:59]

You can then remove -init.

Ideally, we would have:

@interface CVI
@property(readonly) type
(no init redeclaration)
@end

@interface CVI (CVC)
@property(readwrite) type
- initWithType:
@end

[Moe, 2017/04/14 02:55:38]

RE: -init Done.
I see a couple of problems with moving -initWithType: to the CVI (CVC)
extension:
- Items that inherit from CVI would have to include the header. So it won't be
exclusive to CVCs anymore.
- all existing CVCs and the new ones will have to include the header. Not only
that's a lot of change, it's also not obvious to the authors of new CVCs that
they need to include the header.

[lpromero, 2017/04/14 11:37:11]

Acknowledged.

 
 // Configures the given cell with the item's information. Override this method
 // to specialize. At this level, only accessibility properties are ported from