Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc

Issue 2814173002: [Web Payments] Prettify the payment sheet rows in some states. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc
diff --git a/chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc b/chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc
index 76efc95d5aaf368e1c5e23ad1a22b6e48fc1b59c..8ff3e3ef6776e9fc79ea61b1c89117fea8515247 100644
--- a/chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc
+++ b/chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc
@@ -60,8 +60,9 @@ IN_PROC_BROWSER_TEST_F(PaymentSheetViewControllerNoShippingTest,
EXPECT_NE(nullptr, dialog_view()->GetViewByID(static_cast<int>(
DialogViewID::PAYMENT_SHEET_SUMMARY_SECTION)));
- EXPECT_NE(nullptr, dialog_view()->GetViewByID(static_cast<int>(
- DialogViewID::PAYMENT_SHEET_PAYMENT_METHOD_SECTION)));
+ EXPECT_NE(nullptr,
+ dialog_view()->GetViewByID(static_cast<int>(
+ DialogViewID::PAYMENT_SHEET_PAYMENT_METHOD_SECTION_BUTTON)));
EXPECT_EQ(nullptr,
dialog_view()->GetViewByID(static_cast<int>(
DialogViewID::PAYMENT_SHEET_SHIPPING_ADDRESS_SECTION)));
@@ -146,6 +147,28 @@ IN_PROC_BROWSER_TEST_F(PaymentSheetViewControllerContactDetailsTest,
EXPECT_NE(nullptr, dialog_view()->GetViewByID(static_cast<int>(
DialogViewID::PAYMENT_SHEET_SUMMARY_SECTION)));
+ EXPECT_NE(nullptr,
+ dialog_view()->GetViewByID(static_cast<int>(
+ DialogViewID::PAYMENT_SHEET_PAYMENT_METHOD_SECTION_BUTTON)));
+ EXPECT_NE(nullptr,
+ dialog_view()->GetViewByID(static_cast<int>(
+ DialogViewID::PAYMENT_SHEET_SHIPPING_ADDRESS_SECTION_BUTTON)));
+ EXPECT_NE(nullptr,
+ dialog_view()->GetViewByID(static_cast<int>(
+ DialogViewID::PAYMENT_SHEET_SHIPPING_OPTION_SECTION_BUTTON)));
+ EXPECT_NE(nullptr,
+ dialog_view()->GetViewByID(static_cast<int>(
+ DialogViewID::PAYMENT_SHEET_CONTACT_INFO_SECTION_BUTTON)));
+}
+
+IN_PROC_BROWSER_TEST_F(PaymentSheetViewControllerContactDetailsTest,
+ AllClickableRowsPresent) {
+ AddCreditCard(autofill::test::GetCreditCard()); // Visa card.
+ AddAutofillProfile(autofill::test::GetFullProfile());
+ InvokePaymentRequestUI();
+
+ EXPECT_NE(nullptr, dialog_view()->GetViewByID(static_cast<int>(
+ DialogViewID::PAYMENT_SHEET_SUMMARY_SECTION)));
EXPECT_NE(nullptr, dialog_view()->GetViewByID(static_cast<int>(
DialogViewID::PAYMENT_SHEET_PAYMENT_METHOD_SECTION)));
EXPECT_NE(nullptr,
« no previous file with comments | « chrome/browser/ui/views/payments/payment_sheet_view_controller.cc ('k') | components/components_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698