Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2814163002: Revert "Pass ElementImpl as a context for resynthesizing types." (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Pass ElementImpl as a context for resynthesizing types." This reverts commit d2a1bdff4a2b53ef627152fda9f720e754ce7def. It causes an exception during pkg/analyzer analysis. package:analyzer/src/fasta/mock_element.dart;package:analyzer/src/fasta/mock_element.dart;MockElement;accept Unhandled exception: NoSuchMethodError: Class 'CompilationUnitElementInDependency' has no instance getter 'typeParameterContext'. Receiver: Instance of 'CompilationUnitElementInDependency' Tried calling: typeParameterContext R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/cb5bba03e22fbe123c7c4bd0adb0bc1fbd2384d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -155 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 16 chunks +39 lines, -30 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 14 chunks +16 lines, -25 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 9 chunks +33 lines, -24 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +0 lines, -76 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-12 17:45:14 UTC) #1
scheglov
Committed patchset #1 (id:1) manually as cb5bba03e22fbe123c7c4bd0adb0bc1fbd2384d1 (presubmit successful).
3 years, 8 months ago (2017-04-12 17:45:50 UTC) #3
Brian Wilkerson
3 years, 8 months ago (2017-04-12 17:56:36 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698