Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 281413006: Win-clang update script: make an auxiliary copy of the sanitizer headers (Closed)

Created:
6 years, 7 months ago by hans
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src
Visibility:
Public.

Description

Win-clang update script: make an auxiliary copy of the sanitizer headers This dir will be put on the include path for MSVC to pick up when invoked as fallback compiler. BUG=345874 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271039

Patch Set 1 #

Patch Set 2 : Revert accidental #define changes #

Total comments: 4

Patch Set 3 : Add comment #

Total comments: 2

Patch Set 4 : Add comment suggested by timurrrr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M build/common.gypi View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M tools/clang/scripts/update.py View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hans
Please take a look.
6 years, 7 months ago (2014-05-15 23:29:57 UTC) #1
Reid Kleckner
lgtm https://codereview.chromium.org/281413006/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/281413006/diff/20001/build/common.gypi#newcode5063 build/common.gypi:5063: 'AdditionalIncludeDirectories': [ Can you comment that MSVC needs ...
6 years, 7 months ago (2014-05-15 23:58:52 UTC) #2
hans
https://codereview.chromium.org/281413006/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/281413006/diff/20001/build/common.gypi#newcode5063 build/common.gypi:5063: 'AdditionalIncludeDirectories': [ On 2014/05/15 23:58:52, Reid Kleckner wrote: > ...
6 years, 7 months ago (2014-05-16 00:20:57 UTC) #3
Timur Iskhodzhanov
LGTM with a suggestion https://codereview.chromium.org/281413006/diff/40001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/281413006/diff/40001/build/common.gypi#newcode5065 build/common.gypi:5065: # invoked via /fallback. Please ...
6 years, 7 months ago (2014-05-16 09:22:43 UTC) #4
hans
https://codereview.chromium.org/281413006/diff/40001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/281413006/diff/40001/build/common.gypi#newcode5065 build/common.gypi:5065: # invoked via /fallback. On 2014/05/16 09:22:43, Timur Iskhodzhanov ...
6 years, 7 months ago (2014-05-16 16:39:47 UTC) #5
hans
The CQ bit was checked by hans@chromium.org
6 years, 7 months ago (2014-05-16 16:40:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/281413006/60001
6 years, 7 months ago (2014-05-16 16:41:20 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 17:03:58 UTC) #8
Message was sent while issue was closed.
Change committed as 271039

Powered by Google App Engine
This is Rietveld 408576698