Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: third_party/WebKit/Source/core/paint/PaintTiming.cpp

Issue 2814123004: Add loading category to PaintTiming trace events (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintTiming.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintTiming.cpp b/third_party/WebKit/Source/core/paint/PaintTiming.cpp
index a9389a325ea656647e06e4abdc15a44250630793..fae6893ff847960b441603f6225449b779476646 100644
--- a/third_party/WebKit/Source/core/paint/PaintTiming.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintTiming.cpp
@@ -67,7 +67,7 @@ void PaintTiming::MarkFirstTextPaint() {
first_text_paint_ = MonotonicallyIncreasingTime();
SetFirstContentfulPaint(first_text_paint_);
TRACE_EVENT_MARK_WITH_TIMESTAMP1(
- "rail,devtools.timeline", "firstTextPaint",
+ "loading,rail,devtools.timeline", "firstTextPaint",
TraceEvent::ToTraceTimestamp(first_text_paint_), "frame", GetFrame());
NotifyPaintTimingChanged();
}
@@ -78,7 +78,7 @@ void PaintTiming::MarkFirstImagePaint() {
first_image_paint_ = MonotonicallyIncreasingTime();
SetFirstContentfulPaint(first_image_paint_);
TRACE_EVENT_MARK_WITH_TIMESTAMP1(
- "rail,devtools.timeline", "firstImagePaint",
+ "loading,rail,devtools.timeline", "firstImagePaint",
TraceEvent::ToTraceTimestamp(first_image_paint_), "frame", GetFrame());
NotifyPaintTimingChanged();
}
@@ -96,7 +96,7 @@ void PaintTiming::SetFirstMeaningfulPaint(double stamp) {
DCHECK_EQ(first_meaningful_paint_, 0.0);
first_meaningful_paint_ = stamp;
TRACE_EVENT_MARK_WITH_TIMESTAMP1(
- "rail,devtools.timeline", "firstMeaningfulPaint",
+ "loading,rail,devtools.timeline", "firstMeaningfulPaint",
TraceEvent::ToTraceTimestamp(first_meaningful_paint_), "frame",
GetFrame());
NotifyPaintTimingChanged();
@@ -140,7 +140,7 @@ void PaintTiming::SetFirstPaint(double stamp) {
if (performance)
performance->AddFirstPaintTiming(first_paint_);
- TRACE_EVENT_INSTANT1("rail,devtools.timeline", "firstPaint",
+ TRACE_EVENT_INSTANT1("loading,rail,devtools.timeline", "firstPaint",
TRACE_EVENT_SCOPE_PROCESS, "frame", GetFrame());
}
@@ -152,7 +152,7 @@ void PaintTiming::SetFirstContentfulPaint(double stamp) {
Performance* performance = GetPerformanceInstance(GetFrame());
if (performance)
performance->AddFirstContentfulPaintTiming(first_contentful_paint_);
- TRACE_EVENT_INSTANT1("rail,devtools.timeline", "firstContentfulPaint",
+ TRACE_EVENT_INSTANT1("loading,rail,devtools.timeline", "firstContentfulPaint",
TRACE_EVENT_SCOPE_PROCESS, "frame", GetFrame());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698