Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5202)

Unified Diff: chrome/browser/google/google_update_settings_unittest.cc

Issue 2814083002: Make the GGRV brand code non-organic. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google/google_update_settings_unittest.cc
diff --git a/chrome/browser/google/google_update_settings_unittest.cc b/chrome/browser/google/google_update_settings_unittest.cc
index 8b3572aa9a62544928f7c5674ff92d929ff3cc74..31c7fda4ccd347401462d68fb307edc4147f79d4 100644
--- a/chrome/browser/google/google_update_settings_unittest.cc
+++ b/chrome/browser/google/google_update_settings_unittest.cc
@@ -50,6 +50,12 @@ TEST_F(GoogleUpdateTest, LastRunTime) {
#endif // defined(OS_WIN)
+TEST_F(GoogleUpdateTest, IsOrganic) {
+ // Test some brand codes to ensure that future changes to this method won't
+ // go unnoticed.
+ EXPECT_FALSE(google_brand::IsOrganic("GGRV"));
Peter Kasting 2017/04/12 20:05:20 Nit: Also EXPECT_TRUE for GGRsomething_else?
Roger Tawa OOO till Jul 10th 2017/04/12 21:51:43 Do you think I should do all the letters?
Peter Kasting 2017/04/12 22:46:03 Not necessarily, I was mainly thinking of catching
+}
+
TEST_F(GoogleUpdateTest, IsOrganicFirstRunBrandCodes) {
// Test some brand codes to ensure that future changes to this method won't
// go unnoticed.
« chrome/browser/google/google_brand.cc ('K') | « chrome/browser/google/google_brand.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698