[errors] Improve NotGeneric error message

src/builtins/builtins-number.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins-utils.h"
 #include "src/builtins/builtins.h"
 #include "src/code-factory.h"
 #include "src/conversions.h"
 #include "src/counters.h"
 #include "src/objects-inl.h"
@@ skipping 11 matching lines @@
   Handle<Object> fraction_digits = args.atOrUndefined(isolate, 1);
 
   // Unwrap the receiver {value}.
   if (value->IsJSValue()) {
     value = handle(Handle<JSValue>::cast(value)->value(), isolate);
   }
   if (!value->IsNumber()) {
     THROW_NEW_ERROR_RETURN_FAILURE(
         isolate, NewTypeError(MessageTemplate::kNotGeneric,
                               isolate->factory()->NewStringFromAsciiChecked(
-                                  "Number.prototype.toExponential")));
+                                  "Number.prototype.toExponential"),
+                              isolate->factory()->Number_string()));
   }
   double const value_number = value->Number();
 
   // Convert the {fraction_digits} to an integer first.
   ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
       isolate, fraction_digits, Object::ToInteger(isolate, fraction_digits));
   double const fraction_digits_number = fraction_digits->Number();
 
   if (std::isnan(value_number)) return isolate->heap()->nan_string();
   if (std::isinf(value_number)) {
@@ skipping 22 matching lines @@
   Handle<Object> fraction_digits = args.atOrUndefined(isolate, 1);
 
   // Unwrap the receiver {value}.
   if (value->IsJSValue()) {
     value = handle(Handle<JSValue>::cast(value)->value(), isolate);
   }
   if (!value->IsNumber()) {
     THROW_NEW_ERROR_RETURN_FAILURE(
         isolate, NewTypeError(MessageTemplate::kNotGeneric,
                               isolate->factory()->NewStringFromAsciiChecked(
-                                  "Number.prototype.toFixed")));
+                                  "Number.prototype.toFixed"),
+                              isolate->factory()->Number_string()));
   }
   double const value_number = value->Number();
 
   // Convert the {fraction_digits} to an integer first.
   ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
       isolate, fraction_digits, Object::ToInteger(isolate, fraction_digits));
   double const fraction_digits_number = fraction_digits->Number();
 
   // Check if the {fraction_digits} are in the supported range.
   if (fraction_digits_number < 0.0 || fraction_digits_number > 20.0) {
@@ skipping 21 matching lines @@
   Handle<Object> value = args.at(0);
 
   // Unwrap the receiver {value}.
   if (value->IsJSValue()) {
     value = handle(Handle<JSValue>::cast(value)->value(), isolate);
   }
   if (!value->IsNumber()) {
     THROW_NEW_ERROR_RETURN_FAILURE(
         isolate, NewTypeError(MessageTemplate::kNotGeneric,
                               isolate->factory()->NewStringFromAsciiChecked(
-                                  "Number.prototype.toLocaleString")));
+                                  "Number.prototype.toLocaleString"),
+                              isolate->factory()->Number_string()));
   }
 
   // Turn the {value} into a String.
   return *isolate->factory()->NumberToString(value);
 }
 
 // ES6 section 20.1.3.5 Number.prototype.toPrecision ( precision )
 BUILTIN(NumberPrototypeToPrecision) {
   HandleScope scope(isolate);
   Handle<Object> value = args.at(0);
   Handle<Object> precision = args.atOrUndefined(isolate, 1);
 
   // Unwrap the receiver {value}.
   if (value->IsJSValue()) {
     value = handle(Handle<JSValue>::cast(value)->value(), isolate);
   }
   if (!value->IsNumber()) {
     THROW_NEW_ERROR_RETURN_FAILURE(
         isolate, NewTypeError(MessageTemplate::kNotGeneric,
                               isolate->factory()->NewStringFromAsciiChecked(
-                                  "Number.prototype.toPrecision")));
+                                  "Number.prototype.toPrecision"),
+                              isolate->factory()->Number_string()));
   }
   double const value_number = value->Number();
 
   // If no {precision} was specified, just return ToString of {value}.
   if (precision->IsUndefined(isolate)) {
     return *isolate->factory()->NumberToString(value);
   }
 
   // Convert the {precision} to an integer first.
   ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, precision,
@@ skipping 23 matching lines @@
   Handle<Object> radix = args.atOrUndefined(isolate, 1);
 
   // Unwrap the receiver {value}.
   if (value->IsJSValue()) {
     value = handle(Handle<JSValue>::cast(value)->value(), isolate);
   }
   if (!value->IsNumber()) {
     THROW_NEW_ERROR_RETURN_FAILURE(
         isolate, NewTypeError(MessageTemplate::kNotGeneric,
                               isolate->factory()->NewStringFromAsciiChecked(
-                                  "Number.prototype.toString")));
+                                  "Number.prototype.toString"),
+                              isolate->factory()->Number_string()));
   }
   double const value_number = value->Number();
 
   // If no {radix} was specified, just return ToString of {value}.
   if (radix->IsUndefined(isolate)) {
     return *isolate->factory()->NumberToString(value);
   }
 
   // Convert the {radix} to an integer first.
   ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, radix,
@@ skipping 26 matching lines @@
   }
   char* const str =
       DoubleToRadixCString(value_number, static_cast<int>(radix_number));
   Handle<String> result = isolate->factory()->NewStringFromAsciiChecked(str);
   DeleteArray(str);
   return *result;
 }
 
 }  // namespace internal
 }  // namespace v8