Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 2814040: rootdev.c: Added -d option to strip trailing partition number (Closed)

Created:
10 years, 5 months ago by kobi
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, vb
Base URL:
http://src.chromium.org/git/rootdev.git
Visibility:
Public.

Description

rootdev.c: Added -d option to strip trailing partition number Change-Id: I2afbb0a8546f48224292433e2efcf0a868c7a1c6

Patch Set 1 #

Total comments: 1

Patch Set 2 : rootdev.c: Address comment from Bill. (--len in nl) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -9 lines) Patch
M rootdev.c View 1 3 chunks +40 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kobi
10 years, 5 months ago (2010-06-29 18:15:28 UTC) #1
Bill Richardson
LGTM http://codereview.chromium.org/2814040/diff/1/2 File rootdev.c (right): http://codereview.chromium.org/2814040/diff/1/2#newcode43 rootdev.c:43: if (dirnamebuf[len-1] == 'p') --len; put the "--len" ...
10 years, 5 months ago (2010-06-30 15:59:34 UTC) #2
kobi
10 years, 4 months ago (2010-07-14 22:52:40 UTC) #3
kobi
Sorry for the delay. Will submit autotest py script for rootdev shortly as well. (in ...
10 years, 4 months ago (2010-07-14 22:53:45 UTC) #4
kobi
Added test http://codereview.chromium.org/3013013/show
10 years, 4 months ago (2010-07-19 16:46:06 UTC) #5
kobi
Ping?
10 years, 4 months ago (2010-07-23 23:22:52 UTC) #6
brian d
10 years, 4 months ago (2010-07-26 18:47:46 UTC) #7
LGTM.

On 2010/07/23 23:22:52, kobi wrote:
> Ping?

Powered by Google App Engine
This is Rietveld 408576698