Don't show network config UI when networkingPrivate.startConenct fails

extensions/browser/api/networking_private/networking_private_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/networking_private/networking_private_api.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 568 matching lines @@
 
 ExtensionFunction::ResponseAction NetworkingPrivateStartConnectFunction::Run() {
   std::unique_ptr<private_api::StartConnect::Params> params =
       private_api::StartConnect::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(params);
 
   GetDelegate(browser_context())
       ->StartConnect(
           params->network_guid,
           base::Bind(&NetworkingPrivateStartConnectFunction::Success, this),
-          base::Bind(&NetworkingPrivateStartConnectFunction::Failure, this));
+          base::Bind(&NetworkingPrivateStartConnectFunction::Failure, this,
+                     params->network_guid));
   // Success() or Failure() might have been called synchronously at this point.
   // In that case this function has already called Respond(). Return
   // AlreadyResponded() in that case.
   return did_respond() ? AlreadyResponded() : RespondLater();
 }
 
 void NetworkingPrivateStartConnectFunction::Success() {
   Respond(NoArguments());
 }
 
-void NetworkingPrivateStartConnectFunction::Failure(const std::string& error) {
+void NetworkingPrivateStartConnectFunction::Failure(const std::string& guid,
+                                                    const std::string& error) {
+  // TODO(stevenjb): Temporary workaround to show the configuration UI.
+  // Eventually the caller (e.g. Settings) should handle any failures and
+  // show its own configuration UI. crbug.com/380937.
+  if (source_context_type() == Feature::WEBUI_CONTEXT) {

[stevenjb, 2017/04/12 18:14:57]

This seems fine, but I am unfamiliar with the code, thus my caution.

[tbarzic, 2017/04/12 18:50:36]

this checks whether startConnect function was called from web ui rather than an
extension/app.

+    const NetworkingPrivateDelegate::UIDelegate* ui_delegate =
+        GetDelegate(browser_context())->ui_delegate();
+    if (ui_delegate && ui_delegate->HandleConnectFailed(guid, error)) {
+      Success();
+      return;
+    }
+  }

[stevenjb, 2017/04/12 18:14:57]

Did you verify that the dialog shows up on connect failure in OOBE, login
screen, and post login?

[tbarzic, 2017/04/12 18:50:36]

yes I have

   Respond(Error(error));
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NetworkingPrivateStartDisconnectFunction
 
 NetworkingPrivateStartDisconnectFunction::
     ~NetworkingPrivateStartDisconnectFunction() {
 }
 
@@ skipping 410 matching lines @@
   // private_api::GlobalPolicy is a subset of the global policy dictionary
   // (by definition), so use the api setter/getter to generate the subset.
   std::unique_ptr<private_api::GlobalPolicy> policy(
       private_api::GlobalPolicy::FromValue(*policy_dict));
   DCHECK(policy);
   return RespondNow(
       ArgumentList(private_api::GetGlobalPolicy::Results::Create(*policy)));
 }
 
 }  // namespace extensions