src/compiler/verifier.cc - Issue 2814013003: [turbofan] Properly represent the float64 hole.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/verifier.cc

Issue 2814013003: [turbofan] Properly represent the float64 hole. (Closed)

Patch Set: Make sure the_hole has the correct hole NaN bit pattern on Win32. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/verifier.cc

diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc

index cca58a238215cb2eefd364ff3d714229a7453cf5..3c79c67fffb5908f44a4186d4a95df6944938ef6 100644

--- a/src/compiler/verifier.cc

+++ b/src/compiler/verifier.cc

@@ -1201,8 +1201,8 @@ void Verifier::Visitor::Check(Node* node) {

break;

case IrOpcode::kCheckFloat64Hole:

- CheckValueInputIs(node, 0, Type::Number());

- CheckTypeIs(node, Type::Number());

+ CheckValueInputIs(node, 0, Type::NumberOrHole());

+ CheckTypeIs(node, Type::NumberOrUndefined());

break;

case IrOpcode::kCheckTaggedHole:

CheckValueInputIs(node, 0, Type::Any());