chrome/browser/resources/chromeos/keyboard_overlay.js - Issue 2814003002: Add test to check all current accelerators having keyboard overlay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/keyboard_overlay.js

Issue 2814003002: Add test to check all current accelerators having keyboard overlay. (Closed)

Patch Set: Fix nits in patch 2. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | chrome/browser/resources/chromeos/keyboard_overlay_data.js » ('j') | chrome/browser/ui/webui/chromeos/keyboard_overlay_ui_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/keyboard_overlay.js

diff --git a/chrome/browser/resources/chromeos/keyboard_overlay.js b/chrome/browser/resources/chromeos/keyboard_overlay.js

index 5758dc73033b8fb227fa622b45e003ab92b7756a..2891f0cba768701441b5ccee6b223a57b92cb050 100644

--- a/chrome/browser/resources/chromeos/keyboard_overlay.js

+++ b/chrome/browser/resources/chromeos/keyboard_overlay.js

@@ -45,9 +45,11 @@ var LABEL_TO_IDENTIFIER = {

'disabled': 'DISABLED'

};

+// This mapping is maintained for keyboard_overlay_ui_browsertest.

var KEYCODE_TO_LABEL = {

8: 'backspace',

9: 'tab',

+ 10: 'shift',

13: 'enter',

27: 'esc',

32: 'space',

@@ -87,6 +89,15 @@ var KEYCODE_TO_LABEL = {

119: 'mute',

120: 'vol. down',

121: 'vol. up',

+ 152: 'power',

+ 166: 'back',

+ 167: 'forward',

+ 168: 'reload',

+ 173: 'mute',

+ 174: 'vol. down',

+ 175: 'vol. up',

+ 183: 'full screen',

+ 182: 'switch window',

186: ';',

187: '+',

188: ',',

@@ -94,10 +105,14 @@ var KEYCODE_TO_LABEL = {

190: '.',

191: '/',

192: '`',

+ 216: 'bright down',

+ 217: 'bright up',

+ 218: 'bright down',

219: '[',

220: '\\',

221: ']',

222: '\'',

+ 232: 'bright up',

};

/**