Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2813983002: Set WebViewImpl's size in OOPIF processes. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
index 293694f4d24d4915a345b7e5c774cb26e51b23ca..ebce92cd1039d4de565aee9b9eb8b40b74dd3fb0 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
@@ -197,9 +197,11 @@ void WebFrameWidgetImpl::sendResizeEventAndRepaint() {
void WebFrameWidgetImpl::resizeVisualViewport(const WebSize& newSize) {
// TODO(alexmos, kenrb): resizing behavior such as this should be changed
- // to use Page messages. https://crbug.com/599688.
- page()->frameHost().visualViewport().setSize(newSize);
- page()->frameHost().visualViewport().clampToBoundaries();
+ // to use Page messages. This uses the visual viewport size to set size on
+ // both the WebViewImpl size and the Page's VisualViewport. If there are
+ // multiple OOPIFs on a page, this will currently be set redundantly by
+ // each of them. See https://crbug.com/599688.
+ view()->resize(newSize);
view()->didUpdateFullscreenSize();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698