Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: headless/public/headless_browser_context.h

Issue 2813953002: Add HeadlessTabSocket (Closed)
Patch Set: Change HeadlessTabSocketImpl::SetListener Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/tab_socket.mojom ('k') | headless/public/headless_tab_socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/public/headless_browser_context.h
diff --git a/headless/public/headless_browser_context.h b/headless/public/headless_browser_context.h
index 4bdd7a51d7ea8d5b7dc6aced8350c3e237fbf1d4..7f0b48ad0dcdf76c9d72386ddc89d99ba3d0c7f4 100644
--- a/headless/public/headless_browser_context.h
+++ b/headless/public/headless_browser_context.h
@@ -83,14 +83,17 @@ class HEADLESS_EXPORT HeadlessBrowserContext::Builder {
// fetching for different network schemes.
Builder& SetProtocolHandlers(ProtocolHandlerMap protocol_handlers);
- // Specify JS mojo module bindings to be installed, one per mojom file.
- // Note a single mojom file could potentially define many interfaces.
+ // DEPRECATED. Specify JS mojo module bindings to be installed, one per mojom
+ // file. Note a single mojom file could potentially define many interfaces.
// |mojom_name| the name including path of the .mojom file.
// |js_bindings| compiletime generated javascript bindings. Typically loaded
// from gen/path/name.mojom.js.
+ // TODO(alexclarke): Remove this.
Builder& AddJsMojoBindings(const std::string& mojom_name,
const std::string& js_bindings);
+ Builder& AddTabSocketMojoBindings();
+
// By default if you add mojo bindings, http and https are disabled because
// its almost certinly unsafe for arbitary sites on the internet to have
// access to these bindings. If you know what you're doing it may be OK to
« no previous file with comments | « headless/lib/tab_socket.mojom ('k') | headless/public/headless_tab_socket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698