Issue 281393002: Revert of Make all layout tests force composited

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 281393002: Revert of Make all layout tests force composited (Closed)

Created:
6 years, 7 months ago by enne (OOO)

Modified:
6 years, 7 months ago

Reviewers:
ojan, esprehn, adamk, abarth-chromium

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, danakj

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert of Make all layout tests force composited (https://codereview.chromium.org/261143003/) Reason for revert: Breaks content_unittests that are unable to create graphics layers (likely similar to the FrameLoaderClientImplTest here). Original issue's description: > Make all layout tests force composited > > BUG=361729 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174049 TBR=esprehn@chromium.org,ojan@chromium.org,abarth@chromium.org,adamk@chromium.org NOTREECHECKS=true NOTRY=true BUG=361729 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174052

Patch Set 1 #

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -21 lines)			Patch
M	Source/core/frame/Settings.in	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorOverlay.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/testing/DummyPageHolder.cpp	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	Source/web/WebEmbeddedWorkerImpl.cpp	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/web/WebSharedWorkerImpl.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/web/tests/FrameLoaderClientImplTest.cpp	View	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

enne (OOO)

Created Revert of Make all layout tests force composited

6 years, 7 months ago (2014-05-14 23:00:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/281393002/1

6 years, 7 months ago (2014-05-14 23:00:53 UTC) #2

Message was sent while issue was closed.

Change committed as 174052

Expand Messages | Collapse Messages