Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Issue 2813883004: Remove RTCIceTransportPolicy "none". (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
index 98700dde062b3a01e8d74f637314c2c30755cea7..03b8a1b6ec0ce30aff3014e46c2b9e992a670622 100644
--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
@@ -223,8 +223,6 @@ class WebRTCCertificateObserver : public WebRTCCertificateCallback {
};
WebRTCIceTransportPolicy IceTransportPolicyFromString(const String& policy) {
- if (policy == "none")
- return WebRTCIceTransportPolicy::kNone;
if (policy == "relay")
return WebRTCIceTransportPolicy::kRelay;
DCHECK_EQ(policy, "all");
@@ -242,17 +240,10 @@ WebRTCConfiguration ParseConfiguration(ExecutionContext* context,
UseCounter::Count(context, UseCounter::kRTCConfigurationIceTransportPolicy);
ice_transport_policy =
IceTransportPolicyFromString(configuration.iceTransportPolicy());
- if (ice_transport_policy == WebRTCIceTransportPolicy::kNone) {
- UseCounter::Count(context,
- UseCounter::kRTCConfigurationIceTransportPolicyNone);
- }
} else if (configuration.hasIceTransports()) {
UseCounter::Count(context, UseCounter::kRTCConfigurationIceTransports);
ice_transport_policy =
IceTransportPolicyFromString(configuration.iceTransports());
- if (ice_transport_policy == WebRTCIceTransportPolicy::kNone)
- UseCounter::Count(context,
- UseCounter::kRTCConfigurationIceTransportsNone);
foolip 2017/04/12 13:02:40 This should also be removed from UseCounter.h
hbos_chromium 2017/04/13 11:33:42 Done.
}
WebRTCBundlePolicy bundle_policy = WebRTCBundlePolicy::kBalanced;

Powered by Google App Engine
This is Rietveld 408576698