Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 281383012: Add app_list_demo, a standalone executable for testing the app list UI. (Closed)

Created:
6 years, 7 months ago by tapted
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, mac-views-reviews_chromium.org
Visibility:
Public.

Description

Add app_list_demo, a standalone executable for testing the app list UI. This will facilitate development of the out-of-process UI compositor for MacViews by providing a views example that uses UI layers and composited animations. It also gives app list developers a target to ease development of upcoming changes, without compiling all of Chromium and manually installing two dozen apps from the webstore. BUG=365977 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273063

Patch Set 1 #

Patch Set 2 : WebContents is easy #

Patch Set 3 : fix windows #

Patch Set 4 : comment obscure thing #

Patch Set 5 : missing OVERRIDE #

Total comments: 2

Patch Set 6 : rebase to master #

Patch Set 7 : add comment, resolve namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -1 line) Patch
M ui/app_list/app_list.gyp View 1 2 3 4 5 1 chunk +40 lines, -0 lines 0 comments Download
M ui/app_list/views/DEPS View 1 1 chunk +7 lines, -0 lines 0 comments Download
A ui/app_list/views/app_list_demo.cc View 1 2 3 4 5 6 1 chunk +121 lines, -0 lines 0 comments Download
M ui/app_list/views/app_list_view.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tapted
Hi Chris - could you take a look?
6 years, 7 months ago (2014-05-26 06:40:06 UTC) #1
calamity
Looks awesome, lgtm. https://codereview.chromium.org/281383012/diff/100001/ui/app_list/views/app_list_demo.cc File ui/app_list/views/app_list_demo.cc (right): https://codereview.chromium.org/281383012/diff/100001/ui/app_list/views/app_list_demo.cc#newcode57 ui/app_list/views/app_list_demo.cc:57: view_ = new app_list::AppListView(this); Note here ...
6 years, 7 months ago (2014-05-27 03:32:10 UTC) #2
calamity
On 2014/05/27 03:32:10, calamity wrote: > Looks awesome, lgtm. > > https://codereview.chromium.org/281383012/diff/100001/ui/app_list/views/app_list_demo.cc > File ui/app_list/views/app_list_demo.cc ...
6 years, 7 months ago (2014-05-27 03:37:33 UTC) #3
tapted
On 2014/05/27 03:32:10, calamity wrote: > Oh, and FYI, I got some errors when compiling ...
6 years, 7 months ago (2014-05-27 06:20:07 UTC) #4
tapted
+ben for DEPS OWNERS Could you please take a look for: > Missing LGTM from ...
6 years, 7 months ago (2014-05-27 06:23:11 UTC) #5
Ben Goodger (Google)
deps lgtm
6 years, 7 months ago (2014-05-27 15:56:06 UTC) #6
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 7 months ago (2014-05-27 21:38:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/281383012/170001
6 years, 7 months ago (2014-05-27 21:39:08 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 7 months ago (2014-05-27 22:33:25 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 22:49:37 UTC) #10
Message was sent while issue was closed.
Change committed as 273063

Powered by Google App Engine
This is Rietveld 408576698