Create movementX/Y on MouseEvent

Create movementX/Y on MouseEvent.

Part of the larger task of creating an unprefixed Pointer Lock API.
Intent to Implement and Ship approved April 21 2014
http://goo.gl/uQTJjH.

BUG=359738
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175081

[Inactive, 2014-05-22 18:41:12]

lgtm with nit, but this needs API OWNER review as well.

https://codereview.chromium.org/281383010/diff/1/LayoutTests/pointer-lock/mou...
File LayoutTests/pointer-lock/mouse-event-api.html (left):

https://codereview.chromium.org/281383010/diff/1/LayoutTests/pointer-lock/mou...
LayoutTests/pointer-lock/mouse-event-api.html:9:
shouldBeDefined("mouseEvent.webkitMovementX");
Shouldn't we keep those as well since we still support the prefixed version?

[scheib, 2014-05-22 19:47:44]

eseidel for API owners.

https://codereview.chromium.org/281383010/diff/1/LayoutTests/pointer-lock/mou...
File LayoutTests/pointer-lock/mouse-event-api.html (left):

https://codereview.chromium.org/281383010/diff/1/LayoutTests/pointer-lock/mou...
LayoutTests/pointer-lock/mouse-event-api.html:9:
shouldBeDefined("mouseEvent.webkitMovementX");
On 2014/05/22 18:41:13, Chris Dumez wrote:
> Shouldn't we keep those as well since we still support the prefixed version?

Yes, already done. I forked the prefixed version of the layout tests in the
initial patch. LayoutTests/pointer-lock/pointer-lock-api-prefixed.html exists
still.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[Inactive, 2014-05-22 19:50:02]

https://codereview.chromium.org/281383010/diff/1/LayoutTests/pointer-lock/mou...
File LayoutTests/pointer-lock/mouse-event-api.html (left):

https://codereview.chromium.org/281383010/diff/1/LayoutTests/pointer-lock/mou...
LayoutTests/pointer-lock/mouse-event-api.html:9:
shouldBeDefined("mouseEvent.webkitMovementX");
On 2014/05/22 19:47:45, scheib wrote:
> On 2014/05/22 18:41:13, Chris Dumez wrote:
> > Shouldn't we keep those as well since we still support the prefixed version?
> 
> Yes, already done. I forked the prefixed version of the layout tests in the
> initial patch. LayoutTests/pointer-lock/pointer-lock-api-prefixed.html exists
> still.
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 

Oh, right LayoutTests/pointer-lock/mouse-event-api-prefixed.html still exists.
nevermind then.

[eseidel, 2014-05-28 20:44:48]

lgtm

I'm very very sorry.

Thank you for pinging.

I recently did a study of where all the time goes between upload and release for
Blink/Chromium patches (data coming  to blink-dev soon).  The biggest factor is
review-delay, and I'm sure I'm a part of that problem.

[commit-bot: I haz the power, 2014-05-28 20:45:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scheib@chromium.org/281383010/10001

[commit-bot: I haz the power, 2014-05-28 20:45:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 20:45:27]

Failed to apply patch for Source/core/frame/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/UseCounter.h
  Hunk #1 FAILED at 431.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/UseCounter.h.rej

Patch:       Source/core/frame/UseCounter.h
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index
a1cfd2ccd3ffcc2a5d87c066cfecaa870d3d817c..c1b8b30fadce75a956fd88901c7da32ff2144270
100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -431,6 +431,8 @@ public:
         CSSCharsetRuleEncoding = 426,
         DocumentSetCharset = 427,
         DocumentDefaultCharset = 428,
+        MouseEventMovementX = 429,
+        MouseEventMovementY = 430,
         // Add new features immediately above this line. Don't change assigned
         // numbers of any item, and don't reuse removed slots.
         // Also, run update_use_counter_feature_enum.py in
chromium/src/tools/metrics/histograms/

[scheib, 2014-05-28 20:49:33]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2014-05-28 20:50:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scheib@chromium.org/281383010/30001

[commit-bot: I haz the power, 2014-05-28 22:18:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-28 22:19:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 22:19:22]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[scheib, 2014-05-29 14:16:37]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2014-05-29 14:18:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scheib@chromium.org/281383010/30001

[commit-bot: I haz the power, 2014-05-29 14:18:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-29 14:18:19]

Failed to apply patch for Source/core/frame/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/UseCounter.h
  Hunk #1 FAILED at 431.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/UseCounter.h.rej

Patch:       Source/core/frame/UseCounter.h
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index
8adb70c8d349795609a748ba1e34cc575824c4da..5849fe3cdfe58eb1c14dc3f66832c7b0288920d6
100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -431,6 +431,8 @@ public:
         TextEncoderEncode = 430,
         TextDecoderConstructor = 431,
         TextDecoderDecode= 432,
+        MouseEventMovementX = 433,
+        MouseEventMovementY = 434,
         // Add new features immediately above this line. Don't change assigned
         // numbers of any item, and don't reuse removed slots.
         // Also, run update_use_counter_feature_enum.py in
chromium/src/tools/metrics/histograms/

[scheib, 2014-05-29 14:23:26]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2014-05-29 14:24:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scheib@chromium.org/281383010/50001

[commit-bot: I haz the power, 2014-05-30 00:39:44]

Change committed as 175081