Made desktop capture screen tab-constrained in ASH

Made desktop capture screen tab-constrained in ASH.
This should prevent their misterious disapparence when parent window ends up minimized.

BUG=375576
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272619

[Sergey Ulanov, 2014-05-21 18:51:22]

I think it's better to figure out why the window disappears and fix it. 
I intentionally made the dialog non-modal. As a user I would be frustrated if it
was modal. E.g. imagine this scenario:
 - Open hangouts in one tab.
 - Open a doc to be project in a another tab.
 - Click "share screen", the window picker pops up.
 - Realize that I want to project another tab,
 - Try dragging the second tab to a separate window, so that it can be projected
independently of the hangout tab. That won't work if the window picker is modal.

[zel, 2014-05-21 19:57:42]

+glen

Sergey, if this is indeed the use case that we care about, then we should make
this dialog tab-constrained instead.

Right now when you switch to that another tab, the dialog will still stay on top
and require use to manually move it around if that second tab can be used for
anything useful.

If a dialog is always-on-top, then it should be modal - either for the
originating tab (as a tab-constrained dialog), or window, or system.

[Sergey Ulanov, 2014-05-22 18:40:29]

My point was that it looks like a bug in Ash if it doesn't restore non-modal
child windows when parent window is restored after being minimized, and that's
the root cause of the problem. I'll open a separate bug for Ash.

I agree that making the dialog tab-constrained would be a better solution.
Anyway, the way child windows are handled by Aura without Ash is not ideal, so
making this dialog modal probably makes sense for now.
LGTM (I'm not an owner)

On 2014/05/21 19:57:42, zel wrote:
> +glen
> 
> Sergey, if this is indeed the use case that we care about, then we should make
> this dialog tab-constrained instead.
> 
> Right now when you switch to that another tab, the dialog will still stay on
top
> and require use to manually move it around if that second tab can be used for
> anything useful.
> 
> If a dialog is always-on-top, then it should be modal - either for the
> originating tab (as a tab-constrained dialog), or window, or system.

[Sergey Ulanov, 2014-05-22 18:42:23]

Opened crbug.com/376404

[zel, 2014-05-22 23:48:47]

+sky@ as OWNER

[sky, 2014-05-23 00:03:02]

https://codereview.chromium.org/281383008/diff/70001/chrome/browser/ui/views/...
File chrome/browser/ui/views/desktop_media_picker_views.cc (right):

https://codereview.chromium.org/281383008/diff/70001/chrome/browser/ui/views/...
chrome/browser/ui/views/desktop_media_picker_views.cc:191: views::Widget*
widget_;
Why do you need to cache widget_ and override GetWidget. DialogDelegateProvides
an implementation that should do what you want.

[zel, 2014-05-23 17:51:44]

https://codereview.chromium.org/281383008/diff/70001/chrome/browser/ui/views/...
File chrome/browser/ui/views/desktop_media_picker_views.cc (right):

https://codereview.chromium.org/281383008/diff/70001/chrome/browser/ui/views/...
chrome/browser/ui/views/desktop_media_picker_views.cc:191: views::Widget*
widget_;
On 2014/05/23 00:03:02, sky wrote:
> Why do you need to cache widget_ and override GetWidget.
DialogDelegateProvides
> an implementation that should do what you want.

Done.

[sky, 2014-05-23 20:06:11]

LGTM

[zel, 2014-05-23 20:14:56]

The CQ bit was checked by zelidrag@chromium.org

[commit-bot: I haz the power, 2014-05-23 20:15:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zelidrag@chromium.org/281383008/90001

[commit-bot: I haz the power, 2014-05-23 22:19:52]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[commit-bot: I haz the power, 2014-05-23 22:32:16]

Change committed as 272619