Navigation transitions: Added createStyledMarkupForNavigationTransition

Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 82 matching lines @@
 #include "core/dom/TransformSource.h"
 #include "core/dom/TreeWalker.h"
 #include "core/dom/VisitedLinkState.h"
 #include "core/dom/XMLDocument.h"
 #include "core/dom/custom/CustomElementRegistrationContext.h"
 #include "core/dom/shadow/ElementShadow.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/editing/Editor.h"
 #include "core/editing/FrameSelection.h"
 #include "core/editing/SpellChecker.h"
+#include "core/editing/markup.h"
 #include "core/events/BeforeUnloadEvent.h"
 #include "core/events/Event.h"
 #include "core/events/EventFactory.h"
 #include "core/events/EventListener.h"
 #include "core/events/HashChangeEvent.h"
 #include "core/events/PageTransitionEvent.h"
 #include "core/events/ScopedEventQueue.h"
 #include "core/fetch/ResourceFetcher.h"
 #include "core/frame/DOMWindow.h"
 #include "core/frame/FrameConsole.h"
@@ skipping 5595 matching lines @@
     m_taskRunner->postTask(AutofocusTask::create());
 }
 
 Element* Document::activeElement() const
 {
     if (Element* element = treeScope().adjustedFocusedElement())
         return element;
     return body();
 }
 
+void Document::getTransitionElementData(Vector<TransitionElementData>& elementData, ExceptionState& exceptionState)
+{
+    for (HTMLMetaElement* metaElement = head() ? Traversal<HTMLMetaElement>::firstChild(*head()) : 0; metaElement; metaElement = Traversal<HTMLMetaElement>::nextSibling(*metaElement)) {

[esprehn, 2014/06/26 09:32:55]

Lets early return instead.

if (!head())
  return;

[oystein (OOO til 10th of July), 2014/06/26 23:13:43]

Done.

+        if (metaElement->name() != "transition-elements")
+            continue;
+
+        Vector<String> tokens;
+        metaElement->content().string().split(';', tokens);

[esprehn, 2014/06/26 09:32:55]

";" is valid in CSS selectors, I don't think you can do this. ex.
element[attr=";"]. Instead you'll need to get the first index of ";" and then
split take everything before and everything after.

[oystein (OOO til 10th of July), 2014/06/26 23:13:43]

Done.

+        if (tokens.size() != 2)
+            continue;
+
+        RefPtr<NodeList> nodeList = querySelectorAll(AtomicString(tokens[0]), exceptionState);

[esprehn, 2014/06/26 09:32:55]

What happens if the elements you select are nested? Your code is going to make
them into siblings below which is pretty crazy. Your spec is going to need to be
very specific about what you do in here and the CSS handling below.

[oystein (OOO til 10th of July), 2014/06/26 23:13:43]

Sure, there'll be a few "doing this is undefined behavior, please don't" caveats
here.

+        if (!nodeList || exceptionState.hadException())
+            continue;
+
+        String markup;
+        unsigned nodeListLength = nodeList->length();
+        for (unsigned nodeIdx = 0; nodeIdx < nodeListLength; ++nodeIdx) {

[esprehn, 2014/06/26 09:32:55]

nodeIndex, don't abbreviate.

[oystein (OOO til 10th of July), 2014/06/26 23:13:43]

Done.

+            Node* node = nodeList->item(nodeIdx);
+            markup = markup + createStyledMarkupForNavigationTransition(node);

[esprehn, 2014/06/26 09:32:55]

I think there's a string builder for this kind of thing.

[oystein (OOO til 10th of July), 2014/06/26 23:13:43]

Done.

+        }
+
+        if (!markup.isEmpty()) {

[esprehn, 2014/06/26 09:32:55]

How can markup be empty if nodeList was non empty? I suspect you can early
return above instead.

[oystein (OOO til 10th of July), 2014/06/26 23:13:43]

Done.

+            TransitionElementData newElements;
+            newElements.scope = tokens[1];

[esprehn, 2014/06/26 09:32:55]

You'll want to trim() this.

[oystein (OOO til 10th of July), 2014/06/26 23:13:43]

Done.

+            newElements.markup = markup;
+            elementData.append(newElements);
+        }
+    }
+}
+
 bool Document::hasFocus() const
 {
     Page* page = this->page();
     if (!page)
         return false;
     if (!page->focusController().isActive() || !page->focusController().isFocused())
         return false;
     Frame* focusedFrame = page->focusController().focusedFrame();
     if (focusedFrame && focusedFrame->isLocalFrame()) {
         if (toLocalFrame(focusedFrame)->tree().isDescendantOf(frame()))
@@ skipping 126 matching lines @@
     visitor->trace(m_compositorPendingAnimations);
     visitor->trace(m_contextDocument);
     visitor->registerWeakMembers<Document, &Document::clearWeakMembers>(this);
     DocumentSupplementable::trace(visitor);
     TreeScope::trace(visitor);
     ContainerNode::trace(visitor);
     ExecutionContext::trace(visitor);
 }
 
 } // namespace WebCore