Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: src/isolate.h

Issue 2813773002: [inspector] store v8:StackTrace as FixedArray (Closed)
Patch Set: addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/asmjs/asm-typer.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index 3a8d1b3a0380447095958dd67e024dbc2d055c68..471cf2f4afa507799de0d77704f0e57ddfb7b49b 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -717,9 +717,8 @@ class Isolate {
void* ptr2, void* ptr3, void* ptr4,
void* ptr5, void* ptr6, void* ptr7,
void* ptr8, unsigned int magic2));
- Handle<JSArray> CaptureCurrentStackTrace(
- int frame_limit,
- StackTrace::StackTraceOptions options);
+ Handle<FixedArray> CaptureCurrentStackTrace(
+ int frame_limit, StackTrace::StackTraceOptions options);
Handle<Object> CaptureSimpleStackTrace(Handle<JSReceiver> error_object,
FrameSkipMode mode,
Handle<Object> caller);
@@ -728,7 +727,7 @@ class Isolate {
MaybeHandle<JSReceiver> CaptureAndSetSimpleStackTrace(
Handle<JSReceiver> error_object, FrameSkipMode mode,
Handle<Object> caller);
- Handle<JSArray> GetDetailedStackTrace(Handle<JSObject> error_object);
+ Handle<FixedArray> GetDetailedStackTrace(Handle<JSObject> error_object);
// Returns if the given context may access the given global object. If
// the result is false, the pending exception is guaranteed to be
« no previous file with comments | « src/asmjs/asm-typer.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698