dart2js: fast startup cache superclass in inheritance

dart2js: fast startup: cache common superclass in inheritance

- group classes by common superclass
- cache superclass in local to reduce property accesses

Shrinks minified large app by 0.2%

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/835f06a48899da1c59c9707d5064e5a83cb3c3bb

[sra1, 2017-04-11 22:16:59]

Description was changed from

==========
dart2js: fast startup cache superclass in inheritance

BUG=
==========

to

==========
dart2js: fast startup: cache commin superclass in inheritance

- group classes by common superclass
- cache superclass in local to reduce property accesses

Shrinks minified large app by 0.2%

BUG=
==========

[sra1, 2017-04-11 22:16:59]

sra@google.com changed reviewers:
+ floitsch@google.com

[sra1, 2017-04-17 16:50:45]

sra@google.com changed reviewers:
+ sigmund@google.com

[sra1, 2017-04-17 17:24:04]

Description was changed from

==========
dart2js: fast startup: cache commin superclass in inheritance

- group classes by common superclass
- cache superclass in local to reduce property accesses

Shrinks minified large app by 0.2%

BUG=
==========

to

==========
dart2js: fast startup: cache common superclass in inheritance

- group classes by common superclass
- cache superclass in local to reduce property accesses

Shrinks minified large app by 0.2%

BUG=
==========

[Siggi Cherem (dart-lang), 2017-04-17 20:16:20]

lgtm

https://codereview.chromium.org/2813743003/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/2813743003/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:837: void
emitInheritanceForClass(cls) {
nit: maybe rename:
 emittedClasses => seen
 emitInherianceForClass => registerInheritance

(now that you are not adding the inheritCalls until later "emit" seems a bit of
a misnomer here)

[sra1, 2017-04-17 21:44:06]

https://codereview.chromium.org/2813743003/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/2813743003/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:837: void
emitInheritanceForClass(cls) {
On 2017/04/17 20:16:20, Siggi Cherem (dart-lang) wrote:
> nit: maybe rename:
>  emittedClasses => seen
>  emitInherianceForClass => registerInheritance
> 
> (now that you are not adding the inheritCalls until later "emit" seems a bit
of
> a misnomer here)

Done.

[sra1, 2017-04-17 21:58:07]

Description was changed from

==========
dart2js: fast startup: cache common superclass in inheritance

- group classes by common superclass
- cache superclass in local to reduce property accesses

Shrinks minified large app by 0.2%

BUG=
==========

to

==========
dart2js: fast startup: cache common superclass in inheritance

- group classes by common superclass
- cache superclass in local to reduce property accesses

Shrinks minified large app by 0.2%

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/835f06a48899da1c59c9707d5064e5a83cb3c3bb
==========

[sra1, 2017-04-17 21:58:08]

Committed patchset #2 (id:20001) manually as
835f06a48899da1c59c9707d5064e5a83cb3c3bb (presubmit successful).

[floitsch, 2017-04-18 08:42:34]

LGTM.