Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java

Issue 2813703004: chooser: Don't call mutate on new drawable (Closed)
Patch Set: Address tedchoc's comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java
index b66ff743ac19508069fc643e6e6532d06a22bc3b..8d62138855e1226ba207843fc12d2b3755aa7759 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java
@@ -8,7 +8,6 @@ import android.Manifest;
import android.app.Dialog;
import android.content.Intent;
import android.content.pm.PackageManager;
-import android.graphics.drawable.Drawable;
import android.location.LocationManager;
import android.support.test.filters.LargeTest;
import android.test.MoreAsserts;
@@ -53,11 +52,6 @@ public class BluetoothChooserDialogTest extends ChromeActivityTestCaseBase<Chrom
}
@Override
- Drawable getConnectedIcon() {
- return super.mConnectedIcon;
- }
-
- @Override
void nativeOnDialogFinished(
long nativeBluetoothChooserAndroid, int eventType, String deviceId) {
assertEquals(nativeBluetoothChooserAndroid, mNativeBluetoothChooserDialogPtr);
@@ -252,7 +246,7 @@ public class BluetoothChooserDialogTest extends ChromeActivityTestCaseBase<Chrom
assertTrue(itemAdapter.getItem(0).hasSameContents(
"id-1", "Name 1", null /* icon */, null /* iconDescription */));
assertTrue(itemAdapter.getItem(1).hasSameContents("id-2", "Name 2",
- mChooserDialog.getConnectedIcon(), mChooserDialog.mConnectedIconDescription));
+ mChooserDialog.mConnectedIcon, mChooserDialog.mConnectedIconDescription));
selectItem(mChooserDialog, 2);
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698