Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: ui/native_theme/common_theme.cc

Issue 2813703003: Use NativeTheme to draw vertical menu separators. (Closed)
Patch Set: use rectf Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/models/menu_separator_types.h ('k') | ui/native_theme/native_theme.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/native_theme/common_theme.cc
diff --git a/ui/native_theme/common_theme.cc b/ui/native_theme/common_theme.cc
index 9e81966ae53515dec7779ade538a9ed8f5984d69..ddb2eb0551cedca0080c3500b2f9b65a0a0e0b07 100644
--- a/ui/native_theme/common_theme.cc
+++ b/ui/native_theme/common_theme.cc
@@ -70,10 +70,6 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id,
static const SkColor kDisabledMenuItemForegroundColor =
SkColorSetRGB(0xA1, 0xA1, 0x92);
static const SkColor kMenuBorderColor = SkColorSetRGB(0xBA, 0xBA, 0xBA);
- static const SkColor kEnabledMenuButtonBorderColor =
- SkColorSetA(SK_ColorBLACK, 0x24);
- static const SkColor kFocusedMenuButtonBorderColor =
- SkColorSetA(SK_ColorBLACK, 0x48);
static const SkColor kMenuSeparatorColor = SkColorSetRGB(0xE9, 0xE9, 0xE9);
static const SkColor kEnabledMenuItemForegroundColor = SK_ColorBLACK;
// Separator:
@@ -169,11 +165,6 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id,
return kSelectedMenuItemForegroundColor;
case NativeTheme::kColorId_MenuBorderColor:
return kMenuBorderColor;
- case NativeTheme::kColorId_EnabledMenuButtonBorderColor:
- return kEnabledMenuButtonBorderColor;
- case NativeTheme::kColorId_FocusedMenuButtonBorderColor:
- case NativeTheme::kColorId_HoverMenuButtonBorderColor:
- return kFocusedMenuButtonBorderColor;
case NativeTheme::kColorId_MenuSeparatorColor:
return kMenuSeparatorColor;
case NativeTheme::kColorId_MenuBackgroundColor:
@@ -266,8 +257,7 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id,
return base_theme->GetSystemColor(
NativeTheme::kColorId_MenuBackgroundColor);
case NativeTheme::kColorId_TableHeaderSeparator:
- return base_theme->GetSystemColor(
- NativeTheme::kColorId_EnabledMenuButtonBorderColor);
+ return base_theme->GetSystemColor(NativeTheme::kColorId_MenuBorderColor);
// FocusableBorder
case NativeTheme::kColorId_FocusedBorderColor:
« no previous file with comments | « ui/base/models/menu_separator_types.h ('k') | ui/native_theme/native_theme.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698