Chromium Code Reviews| Index: components/translate/ios/browser/language_detection_controller_unittest.mm |
| diff --git a/components/translate/ios/browser/language_detection_controller_unittest.mm b/components/translate/ios/browser/language_detection_controller_unittest.mm |
| index d40361b309be31d0d0a4c14c507f2e777c4ebba9..63599d8ca447bdf3dd768919d5e233f8d499091a 100644 |
| --- a/components/translate/ios/browser/language_detection_controller_unittest.mm |
| +++ b/components/translate/ios/browser/language_detection_controller_unittest.mm |
| @@ -14,6 +14,10 @@ |
| #include "testing/gtest/include/gtest/gtest.h" |
| #include "testing/platform_test.h" |
| +#if !defined(__has_feature) || !__has_feature(objc_arc) |
| +#error "This file requires ARC support." |
| +#endif |
| + |
| @interface MockJsLanguageDetectionManager : JsLanguageDetectionManager |
| @end |
| @@ -33,10 +37,10 @@ class LanguageDetectionControllerTest : public PlatformTest { |
| LanguageDetectionControllerTest() { |
| prefs_.registry()->RegisterBooleanPref(prefs::kEnableTranslate, true); |
| - base::scoped_nsobject<MockJsLanguageDetectionManager> js_manager( |
| - [[MockJsLanguageDetectionManager alloc] init]); |
| - controller_.reset(new LanguageDetectionController( |
| - &web_state_, js_manager.get(), &prefs_)); |
| + MockJsLanguageDetectionManager* js_manager = |
| + [[MockJsLanguageDetectionManager alloc] init]; |
| + controller_.reset( |
| + new LanguageDetectionController(&web_state_, js_manager, &prefs_)); |
|
sdefresne
2017/04/11 07:45:32
Please use the opportunity to change this to base:
stkhapugin
2017/04/11 15:33:33
Done.
|
| } |
| LanguageDetectionController* controller() { return controller_.get(); } |
| @@ -57,7 +61,7 @@ TEST_F(LanguageDetectionControllerTest, OnTextCaptured) { |
| __block bool block_was_called = false; |
| auto subscription = |
| - controller()->RegisterLanguageDetectionCallback(base::BindBlock( |
| + controller()->RegisterLanguageDetectionCallback(base::BindBlockArc( |
| ^(const LanguageDetectionController::DetectionDetails& details) { |
| block_was_called = true; |
| EXPECT_EQ(kRootLanguage, details.html_root_language); |