Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2146)

Unified Diff: content/renderer/idle_user_detector.cc

Issue 2813683002: Allow MainThreadEventQueue to call the RenderWidget directly. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/idle_user_detector.cc
diff --git a/content/renderer/idle_user_detector.cc b/content/renderer/idle_user_detector.cc
index 43979cfb722ebbbb322b822c0d665c78a998475d..268015789c222fdb00a5beeb039fe3a09ef09dfb 100644
--- a/content/renderer/idle_user_detector.cc
+++ b/content/renderer/idle_user_detector.cc
@@ -25,11 +25,7 @@ bool IdleUserDetector::OnMessageReceived(const IPC::Message& message) {
return false;
}
-void IdleUserDetector::OnHandleInputEvent(
- const blink::WebInputEvent* event,
- const std::vector<const blink::WebInputEvent*>& coalesced_events,
- const ui::LatencyInfo& latency_info,
- InputEventDispatchType dispatch_type) {
+void IdleUserDetector::HandleInputMessageReceived() {
mustaq 2017/04/12 19:27:49 This has nothing to do with handling input. Let's
dtapuska 2017/04/13 16:56:24 Done.
if (GetContentClient()->renderer()->RunIdleHandlerWhenWidgetsHidden()) {
RenderThreadImpl* render_thread = RenderThreadImpl::current();
if (render_thread != NULL) {
@@ -38,8 +34,15 @@ void IdleUserDetector::OnHandleInputEvent(
}
}
+void IdleUserDetector::OnHandleInputEvent(
+ const blink::WebInputEvent* event,
+ const std::vector<const blink::WebInputEvent*>& coalesced_events,
+ const ui::LatencyInfo& latency_info,
+ InputEventDispatchType dispatch_type) {
+ HandleInputMessageReceived();
+}
+
void IdleUserDetector::OnDestruct() {
- delete this;
tdresser 2017/04/10 15:54:17 Out of curiosity, why this change? It seems to be
dtapuska 2017/04/10 16:08:05 Because this is a IPC message filter that self del
tdresser 2017/04/10 16:25:00 Acknowledged.
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698