Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 2813603002: Less direct Compiler use in SSA (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/native/ssa.dart » ('j') | pkg/compiler/lib/src/ssa/graph_builder.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/compiler.dart
diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart
index 8f301875771de6fa31a35a797451e87ed14cb142..99767bc78b33c5272a3a65b7a584e4aff0bad9fc 100644
--- a/pkg/compiler/lib/src/compiler.dart
+++ b/pkg/compiler/lib/src/compiler.dart
@@ -295,12 +295,6 @@ abstract class Compiler {
bool get disableTypeInference =>
options.disableTypeInference || compilationFailed;
- // TODO(het): remove this from here. Either inline at all use sites or add it
- // to Reporter.
- void unimplemented(Spannable spannable, String methodName) {
- reporter.internalError(spannable, "$methodName not implemented.");
- }
-
// Compiles the dart script at [uri].
//
// The resulting future will complete with true if the compilation
@@ -927,8 +921,8 @@ abstract class Compiler {
* See [LibraryLoader] for terminology on URIs.
*/
Future<Script> readScript(Uri readableUri, [Spannable node]) {
- unimplemented(node, 'Compiler.readScript');
- return null;
+ throw new SpannableAssertionFailure(
+ node, 'Compiler.readScript not implemented.');
}
Element lookupElementIn(ScopeContainerElement container, String name) {
« no previous file with comments | « no previous file | pkg/compiler/lib/src/native/ssa.dart » ('j') | pkg/compiler/lib/src/ssa/graph_builder.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698