Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2813553006: Split error code to ease future improvements (Closed)

Created:
3 years, 8 months ago by Brian Wilkerson
Modified:
3 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -17 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/error/error.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 2 chunks +39 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +12 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 3 chunks +33 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 8 months ago (2017-04-11 20:27:36 UTC) #2
scheglov
LGTM
3 years, 8 months ago (2017-04-11 20:31:38 UTC) #3
Brian Wilkerson
3 years, 8 months ago (2017-04-11 20:35:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3dcf0e31c5f9402ff48e22662c792b56bbe9e4db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698