Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2813543007: Pass ElementImpl as a context for resynthesizing types. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pass ElementImpl as a context for resynthesizing types. We need to do this in order to associate resynthesized GenericFunctionTypeElementImpl instances with these enclosing ElementImpl instances. The same enclosing ElementImpl can also be used to get the TypeParameterizedElementMixin for accessing type parameters. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d2a1bdff4a2b53ef627152fda9f720e754ce7def

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -88 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 16 chunks +30 lines, -39 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 14 chunks +25 lines, -16 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 9 chunks +24 lines, -33 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 8 months ago (2017-04-12 15:56:55 UTC) #1
Paul Berry
lgtm
3 years, 8 months ago (2017-04-12 16:06:01 UTC) #2
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-12 16:32:35 UTC) #3
scheglov
3 years, 8 months ago (2017-04-12 16:36:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d2a1bdff4a2b53ef627152fda9f720e754ce7def (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698