Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp

Issue 2813533003: Add "Unicode" suffixes to some functions of WTF::String and WTF::StringImpl. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp
diff --git a/third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp b/third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp
index bca6443e01d71342a351e64ca1e842734886d942..4bb9f41c6380f1a27c9f43719d62ed351258a6f5 100644
--- a/third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp
+++ b/third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp
@@ -633,7 +633,7 @@ PassRefPtr<StringImpl> StringImpl::LowerASCII() {
return new_impl.Release();
}
-PassRefPtr<StringImpl> StringImpl::Lower() {
+PassRefPtr<StringImpl> StringImpl::LowerUnicode() {
// Note: This is a hot function in the Dromaeo benchmark, specifically the
// no-op code path up through the first 'return' statement.
@@ -710,9 +710,9 @@ PassRefPtr<StringImpl> StringImpl::Lower() {
return new_impl.Release();
}
-PassRefPtr<StringImpl> StringImpl::Upper() {
- // This function could be optimized for no-op cases the way lower() is,
- // but in empirical testing, few actual calls to upper() are no-ops, so
+PassRefPtr<StringImpl> StringImpl::UpperUnicode() {
+ // This function could be optimized for no-op cases the way LowerUnicode() is,
+ // but in empirical testing, few actual calls to UpperUnicode() are no-ops, so
// it wouldn't be worth the extra time for pre-scanning.
RELEASE_ASSERT(length_ <=
@@ -871,7 +871,7 @@ static PassRefPtr<StringImpl> CaseConvert(const UChar* source16,
} while (true);
}
-PassRefPtr<StringImpl> StringImpl::Lower(
+PassRefPtr<StringImpl> StringImpl::LowerUnicode(
const AtomicString& locale_identifier) {
// Use the more optimized code path most of the time.
// Only Turkic (tr and az) languages and Lithuanian requires
@@ -886,7 +886,7 @@ PassRefPtr<StringImpl> StringImpl::Lower(
else if (LocaleIdMatchesLang(locale_identifier, "lt"))
locale_for_conversion = "lt";
else
- return Lower();
+ return LowerUnicode();
if (length_ > static_cast<unsigned>(numeric_limits<int32_t>::max()))
CRASH();
@@ -898,7 +898,7 @@ PassRefPtr<StringImpl> StringImpl::Lower(
this);
}
-PassRefPtr<StringImpl> StringImpl::Upper(
+PassRefPtr<StringImpl> StringImpl::UpperUnicode(
const AtomicString& locale_identifier) {
// Use the more-optimized code path most of the time.
// Only Turkic (tr and az) languages, Greek and Lithuanian require
@@ -912,7 +912,7 @@ PassRefPtr<StringImpl> StringImpl::Upper(
else if (LocaleIdMatchesLang(locale_identifier, "lt"))
locale_for_conversion = "lt";
else
- return Upper();
+ return UpperUnicode();
if (length_ > static_cast<unsigned>(numeric_limits<int32_t>::max()))
CRASH();

Powered by Google App Engine
This is Rietveld 408576698