Mojo: nuke EnvironmentData

Mojo: nuke EnvironmentData

With this change, Mojo applications that link against mojo_environment_chromium
do not need to instantiate mojo::Environment. We rely on AtExitManager for all
finalization of singleton objects. This frees us up to use the familiar
base::Singleton and base::LazyInstance for any such state. Tests can use
ShadowingAtExitManager to clean the environment between test runs.

It becomes a link error to use mojo::Environment if you are not linking against
mojo_environment_standalone. I plan to follow this up with a change that buries
mojo::Environment for the case where you are linking against
mojo_environment_standalone. Ideally, this means no one will ever need to think
about mojo::Environment again.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277265

[darin (slow to review), 2014-05-15 03:54:25]

This depends on https://codereview.chromium.org/282823003/

[darin (slow to review), 2014-05-15 23:46:18]

sky: this is ready for review

[sky, 2014-05-16 15:14:53]

Nice, LGTM

[darin (slow to review), 2014-05-16 15:35:53]

The CQ bit was checked by darin@chromium.org

[commit-bot: I haz the power, 2014-05-16 15:36:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/darin@chromium.org/281353005/80001

[commit-bot: I haz the power, 2014-05-16 15:52:43]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-16 15:56:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 15:56:01]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[darin (slow to review), 2014-05-16 18:20:02]

The CQ bit was checked by darin@chromium.org

[commit-bot: I haz the power, 2014-05-16 18:20:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/darin@chromium.org/281353005/100001

[darin (slow to review), 2014-05-17 04:42:43]

The CQ bit was checked by darin@chromium.org

[commit-bot: I haz the power, 2014-05-17 04:43:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/darin@chromium.org/281353005/120001

[commit-bot: I haz the power, 2014-05-17 10:46:40]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[commit-bot: I haz the power, 2014-05-17 11:04:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-17 11:04:09]

Try jobs failed on following builders:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[darin (slow to review), 2014-05-17 20:40:41]

The CQ bit was checked by darin@chromium.org

[commit-bot: I haz the power, 2014-05-17 20:40:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/darin@chromium.org/281353005/140001

[commit-bot: I haz the power, 2014-05-17 22:16:49]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-17 22:52:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-17 22:52:45]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[darin (slow to review), 2014-05-22 23:40:56]

The CQ bit was checked by darin@chromium.org

[commit-bot: I haz the power, 2014-05-22 23:43:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/darin@chromium.org/281353005/180001

[darin (slow to review), 2014-05-23 03:15:48]

The CQ bit was checked by darin@chromium.org

[commit-bot: I haz the power, 2014-05-23 03:17:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/darin@chromium.org/281353005/200001

[commit-bot: I haz the power, 2014-05-23 10:41:16]

Change committed as 272472

[Ken Russell (switch to Gerrit), 2014-05-23 21:02:24]

On 2014/05/23 10:41:16, I haz the power (commit-bot) wrote:
> Change committed as 272472

This CL caused layout test hangs on Windows; see http://crbug.com/376929. I
reverted it in r272589.

[darin (slow to review), 2014-05-24 17:07:44]

The CQ bit was checked by darin@chromium.org

[darin (slow to review), 2014-05-24 17:07:44]

The CQ bit was unchecked by darin@chromium.org

[darin (slow to review), 2014-06-13 06:17:56]

The CQ bit was checked by darin@chromium.org

[commit-bot: I haz the power, 2014-06-13 06:20:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/darin@chromium.org/281353005/320001

[commit-bot: I haz the power, 2014-06-13 08:23:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-13 09:38:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 09:38:45]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[qsr, 2014-06-13 09:53:04]

https://codereview.chromium.org/281353005/diff/320001/mojo/android/javatests/...
File mojo/android/javatests/mojo_test_case.cc (left):

https://codereview.chromium.org/281353005/diff/320001/mojo/android/javatests/...
mojo/android/javatests/mojo_test_case.cc:20: mojo::Environment environment;
Any reason not to put a shadow at_exit manager here? We want clean environment
between each test.

[darin (slow to review), 2014-06-13 20:08:15]

On 2014/06/13 09:53:04, qsr wrote:
>
https://codereview.chromium.org/281353005/diff/320001/mojo/android/javatests/...
> File mojo/android/javatests/mojo_test_case.cc (left):
> 
>
https://codereview.chromium.org/281353005/diff/320001/mojo/android/javatests/...
> mojo/android/javatests/mojo_test_case.cc:20: mojo::Environment environment;
> Any reason not to put a shadow at_exit manager here? We want clean environment
> between each test.

I'll give it a try.

[darin (slow to review), 2014-06-13 23:43:16]

https://codereview.chromium.org/281353005/diff/320001/mojo/android/javatests/...
File mojo/android/javatests/mojo_test_case.cc (left):

https://codereview.chromium.org/281353005/diff/320001/mojo/android/javatests/...
mojo/android/javatests/mojo_test_case.cc:20: mojo::Environment environment;
On 2014/06/13 09:53:04, qsr wrote:
> Any reason not to put a shadow at_exit manager here? We want clean environment
> between each test.

Done.

[darin (slow to review), 2014-06-13 23:49:53]

The CQ bit was checked by darin@chromium.org

[commit-bot: I haz the power, 2014-06-13 23:50:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/darin@chromium.org/281353005/340001

[darin (slow to review), 2014-06-14 03:15:15]

The CQ bit was checked by darin@chromium.org

[commit-bot: I haz the power, 2014-06-14 03:16:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/darin@chromium.org/281353005/360001

[darin (slow to review), 2014-06-14 06:35:57]

The CQ bit was checked by darin@chromium.org

[commit-bot: I haz the power, 2014-06-14 06:37:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/darin@chromium.org/281353005/380001

[commit-bot: I haz the power, 2014-06-14 20:18:32]

Change committed as 277265