Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: pkg/shelf/lib/shelf_io.dart

Issue 281353004: pkg/shelf: Fixed logic for setting Server header in `shelf_io` (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: final nits Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/shelf/CHANGELOG.md ('k') | pkg/shelf/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/shelf/lib/shelf_io.dart
diff --git a/pkg/shelf/lib/shelf_io.dart b/pkg/shelf/lib/shelf_io.dart
index 6582e5a0688658b38c628629981dfb47bb9ae35d..c6853025bd94d39b665d319bef3a6dbc20474c82 100644
--- a/pkg/shelf/lib/shelf_io.dart
+++ b/pkg/shelf/lib/shelf_io.dart
@@ -117,9 +117,8 @@ Future _writeResponse(Response response, HttpResponse httpResponse) {
httpResponse.headers.set(header, value);
});
- if (response.headers[HttpHeaders.SERVER] == null) {
- var value = httpResponse.headers.value(HttpHeaders.SERVER);
- httpResponse.headers.set(HttpHeaders.SERVER, '$value with Shelf');
+ if (!response.headers.containsKey(HttpHeaders.SERVER)) {
+ httpResponse.headers.set(HttpHeaders.SERVER, 'dart:io with Shelf');
}
if (!response.headers.containsKey(HttpHeaders.DATE)) {
« no previous file with comments | « pkg/shelf/CHANGELOG.md ('k') | pkg/shelf/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698