pkg/shelf: Fixed logic for setting Server header in `shelf_io`

pkg/shelf/lib/shelf_io.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// A Shelf adapter for handling [HttpRequest] objects from `dart:io`.
 ///
 /// One can provide an instance of [HttpServer] as the `requests` parameter in
 /// [serveRequests].
 library shelf.io;
 
@@ skipping 69 matching lines @@
 }
 
 Future _writeResponse(Response response, HttpResponse httpResponse) {
   httpResponse.statusCode = response.statusCode;
 
   response.headers.forEach((header, value) {
     if (value == null) return;
     httpResponse.headers.set(header, value);
   });
 
-  if (response.headers[HttpHeaders.SERVER] == null) {
-    var value = httpResponse.headers.value(HttpHeaders.SERVER);
-    httpResponse.headers.set(HttpHeaders.SERVER, '$value with Shelf');
-  }

[nweiz, 2014/05/15 22:21:32]

I still like the intent of this code, even if it didn't work correctly. Can you
figure out how dart:io's server computes its default header and use the same
logic here?

   return httpResponse.addStream(response.read())
       .then((_) => httpResponse.close());
 }
 
 // TODO(kevmoo) A developer mode is needed to include error info in response
 // TODO(kevmoo) Make error output plugable. stderr, logging, etc
 Response _logError(String message, [StackTrace stackTrace]) {
   var chain = new Chain.current();
   if (stackTrace != null) {
     chain = new Chain.forTrace(stackTrace);
   }
   chain = chain
       .foldFrames((frame) => frame.isCore || frame.package == 'shelf')
       .terse;
 
   stderr.writeln('ERROR - ${new DateTime.now()}');
   stderr.writeln(message);
   stderr.writeln(chain);
   return new Response.internalServerError();
 }