Extract ClosedWorldBase from ClosedWorldImpl

Extract ClosedWorldBase from ClosedWorldImpl

This is step towards making (parts of) ClosedWorldImpl reusable for kernel based elements.

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/aef0c45019d23f1c1274eda9bfdb9356507d1757

[Johnni Winther, 2017-04-11 12:07:30]

johnniwinther@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-04-11 19:39:32]

lgtm

https://codereview.chromium.org/2813503005/diff/1/pkg/compiler/lib/src/world....
File pkg/compiler/lib/src/world.dart (right):

https://codereview.chromium.org/2813503005/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:831: mask ??= commonMasks.dynamicType;
this line suggests mask is optional. Should we mark it as such in the signature?

(same in other methods below)

(I know you just moved these functions around, but still)

https://codereview.chromium.org/2813503005/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:845: if (!element.isField) return false;
throw?

https://codereview.chromium.org/2813503005/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:919: // TODO(johnniwinther): Reinsert this or
similar invariant.
Can you add a little more info to this TODO? What conditions must be true to
reinsert it?

[Johnni Winther, 2017-04-12 07:52:35]

https://codereview.chromium.org/2813503005/diff/1/pkg/compiler/lib/src/world....
File pkg/compiler/lib/src/world.dart (right):

https://codereview.chromium.org/2813503005/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:831: mask ??= commonMasks.dynamicType;
On 2017/04/11 19:39:31, Emily Fortuna wrote:
> this line suggests mask is optional. Should we mark it as such in the
signature?
> 
> (same in other methods below)
> 
> (I know you just moved these functions around, but still)

It's not optional - it just might not have been computed yet for the call site -
meaning that it is dynamic.

https://codereview.chromium.org/2813503005/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:845: if (!element.isField) return false;
On 2017/04/11 19:39:31, Emily Fortuna wrote:
> throw?

I'll look into this. MemberEntity should be FieldEntity but we have some noise.

https://codereview.chromium.org/2813503005/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:919: // TODO(johnniwinther): Reinsert this or
similar invariant.
On 2017/04/11 19:39:31, Emily Fortuna wrote:
> Can you add a little more info to this TODO? What conditions must be true to
> reinsert it?

Done.

[Johnni Winther, 2017-04-12 07:52:49]

Description was changed from

==========
Extract ClosedWorldBase from ClosedWorldImpl

This is step towards making (parts of) ClosedWorldImpl reusable for kernel based
elements.
==========

to

==========
Extract ClosedWorldBase from ClosedWorldImpl

This is step towards making (parts of) ClosedWorldImpl reusable for kernel based
elements.

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/aef0c45019d23f1c1274eda9bfdb9356507d1757
==========

[Johnni Winther, 2017-04-12 07:52:50]

Committed patchset #2 (id:20001) manually as
aef0c45019d23f1c1274eda9bfdb9356507d1757 (presubmit successful).