chrome/browser/resources/md_bookmarks/item.js - Issue 2813503002: MD Bookmarks: Prevent navigating to invalid folders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_bookmarks/item.js

Issue 2813503002: MD Bookmarks: Prevent navigating to invalid folders (Closed)

Patch Set: handleAction -> dispatch Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/md_bookmarks/item.js

diff --git a/chrome/browser/resources/md_bookmarks/item.js b/chrome/browser/resources/md_bookmarks/item.js

index d761f6532353608694cbc410f521a5a6be321403..d976fdcac495a51ea561ed1f228093ebfe8d6e5b 100644

--- a/chrome/browser/resources/md_bookmarks/item.js

+++ b/chrome/browser/resources/md_bookmarks/item.js

@@ -107,10 +107,12 @@ Polymer({

* @private

onDblClick_: function(e) {

- if (!this.item_.url)

- this.dispatch(bookmarks.actions.selectFolder(this.item_.id));

- else

+ if (!this.item_.url) {

+ this.dispatch(

+ bookmarks.actions.selectFolder(this.item_.id, this.getState().nodes));

+ } else {

chrome.tabs.create({url: this.item_.url});

+ }

/**