Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 2813493003: Fix a crash on Mac due to TextInputManager being null (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index 2b0a11d2a17b90d248e7fd40e21649042cd28697..a6803570beb3521971042ad90777b9780bbf1a07 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -564,7 +564,8 @@ RenderWidgetHostImpl* RenderWidgetHostViewMac::GetActiveWidget() {
const TextInputManager::CompositionRangeInfo*
RenderWidgetHostViewMac::GetCompositionRangeInfo() {
- return text_input_manager_->GetCompositionRangeInfo();
+ return GetTextInputManager() ? text_input_manager_->GetCompositionRangeInfo()
EhsanK 2017/04/10 15:30:39 This is similar to lines 557 and 561 above. I thin
+ : nullptr;
}
const TextInputManager::TextSelection*
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698