Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2813483002: Add snake_case name utility. (Closed)

Created:
3 years, 8 months ago by shend
Modified:
3 years, 8 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add snake_case name utility. With the Blink rename, member variables use snake case followed by an underscore. This patch adds snake_case to name utilities so that this logic is clearer and can be reused. BUG=628043 Review-Url: https://codereview.chromium.org/2813483002 Cr-Commit-Position: refs/heads/master@{#465112} Committed: https://chromium.googlesource.com/chromium/src/+/00ef28764c3fcbc09c08259a871a481cb2b34d89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/build/scripts/name_utilities.py View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
shend
Hi Bugs, PTAL :)
3 years, 8 months ago (2017-04-10 04:06:54 UTC) #2
Bugs Nash
On 2017/04/10 at 04:06:54, shend wrote: > Hi Bugs, PTAL :) lgtm, definitely clearer
3 years, 8 months ago (2017-04-11 03:26:15 UTC) #3
shend
Hi Eddy, PTAL
3 years, 8 months ago (2017-04-12 04:10:53 UTC) #9
shend
Redirecting to Suzy, PTAL :)
3 years, 8 months ago (2017-04-17 23:57:17 UTC) #11
suzyh_UTC10 (ex-contributor)
On 2017/04/17 at 23:57:17, shend wrote: > Redirecting to Suzy, PTAL :) TIL the phrase ...
3 years, 8 months ago (2017-04-18 00:01:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813483002/1
3 years, 8 months ago (2017-04-18 01:04:01 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 02:38:54 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00ef28764c3fcbc09c08259a871a...

Powered by Google App Engine
This is Rietveld 408576698