[sync] Fix decryption failure caused by missing user_key

components/sync/base/nigori_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync/base/nigori.h"
 
 #include "base/strings/string_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace syncer {
 namespace {
 
 TEST(SyncNigoriTest, Permute) {

[pavely, 2017/04/10 21:27:29]

Could you add tests that InitByDerivation populates user_key_ while InitByImport
doesn't fail if user_key_ is not present.

[Patrick Noland, 2017/04/10 23:43:06]

Done.

   Nigori nigori;
   EXPECT_TRUE(nigori.InitByDerivation("example.com", "username", "password"));
 
   std::string permuted;
   EXPECT_TRUE(nigori.Permute(Nigori::Password, "test name", &permuted));
 
   std::string expected =
       "prewwdJj2PrGDczvmsHJEE5ndcCyVze8sY9kD5hjY/Tm"
       "c5kOjXFK7zB3Ss4LlHjEDirMu+vh85JwHOnGrMVe+g==";
   EXPECT_EQ(expected, permuted);
@@ skipping 95 matching lines @@
   std::string decrypted;
   EXPECT_FALSE(nigori.Decrypt(encrypted, &decrypted));
 
   EXPECT_NE(plaintext, decrypted);
 }
 
 TEST(SyncNigoriTest, ExportImport) {
   Nigori nigori1;
   EXPECT_TRUE(nigori1.InitByDerivation("example.com", "username", "password"));
 
+  std::string user_key;
   std::string encryption_key;
   std::string mac_key;
-  EXPECT_TRUE(nigori1.ExportKeys(&encryption_key, &mac_key));
+  EXPECT_TRUE(nigori1.ExportKeys(&user_key, &encryption_key, &mac_key));
 
   Nigori nigori2;
-  EXPECT_TRUE(nigori2.InitByImport(encryption_key, mac_key));
+  EXPECT_TRUE(nigori2.InitByImport(user_key, encryption_key, mac_key));
 
   std::string original("test");
   std::string plaintext;
   std::string ciphertext;
 
   EXPECT_TRUE(nigori1.Encrypt(original, &ciphertext));
   EXPECT_TRUE(nigori2.Decrypt(ciphertext, &plaintext));
   EXPECT_EQ(original, plaintext);
 
   EXPECT_TRUE(nigori2.Encrypt(original, &ciphertext));
   EXPECT_TRUE(nigori1.Decrypt(ciphertext, &plaintext));
   EXPECT_EQ(original, plaintext);
 
   std::string permuted1, permuted2;
   EXPECT_TRUE(nigori1.Permute(Nigori::Password, original, &permuted1));
   EXPECT_TRUE(nigori2.Permute(Nigori::Password, original, &permuted2));
   EXPECT_EQ(permuted1, permuted2);
 }
 
 }  // anonymous namespace
 }  // namespace syncer