third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp - Issue 2813433002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp

Issue 2813433002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase (Closed)

Patch Set: rebase and assert -> dcheck Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/SQLResultSet.cpp ('k') | third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp » ('j') | third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp

diff --git a/third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp b/third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp

index 1e25a86d102c3b391166e8ba1009292dfdcc3b07..1d13b20c36714462cde207d90a1e2b1af274bf8f 100644

--- a/third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp

+++ b/third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp

@@ -39,7 +39,7 @@ unsigned SQLResultSetRowList::length() const {

if (result_.size() == 0)

return 0;

- ASSERT(result_.size() % columns_.size() == 0);

+ DCHECK_EQ(result_.size() % columns_.size(), 0);

return result_.size() / columns_.size();

}