Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase

third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp

 /*
  * Copyright (C) 2012 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 51 matching lines @@
 
 // This is just for ignoring DatabaseCallback::handleEvent()'s return value.
 static void DatabaseCallbackHandleEvent(DatabaseCallback* callback,
                                         Database* database) {
   probe::AsyncTask async_task(database->GetExecutionContext(), callback);
   callback->handleEvent(database);
 }
 
 DatabaseContext* DatabaseManager::ExistingDatabaseContextFor(
     ExecutionContext* context) {
-  ASSERT(database_context_registered_count_ >= 0);
-  ASSERT(database_context_instance_count_ >= 0);
-  ASSERT(database_context_registered_count_ <=
-         database_context_instance_count_);
+  DCHECK_GE(database_context_registered_count_, 0);
+  DCHECK_GE(database_context_instance_count_, 0);
+  DCHECK_LE(database_context_registered_count_,
+            database_context_instance_count_);
   return context_map_.at(context);
 }
 
 DatabaseContext* DatabaseManager::DatabaseContextFor(
     ExecutionContext* context) {
   if (DatabaseContext* database_context = ExistingDatabaseContextFor(context))
     return database_context;
   return DatabaseContext::Create(context);
 }
 
 void DatabaseManager::RegisterDatabaseContext(
     DatabaseContext* database_context) {
   ExecutionContext* context = database_context->GetExecutionContext();
   context_map_.Set(context, database_context);
 #if DCHECK_IS_ON()
   database_context_registered_count_++;
 #endif
 }
 
 void DatabaseManager::UnregisterDatabaseContext(
     DatabaseContext* database_context) {
   ExecutionContext* context = database_context->GetExecutionContext();
-  ASSERT(context_map_.at(context));
+  DCHECK(context_map_.at(context));
 #if DCHECK_IS_ON()
   database_context_registered_count_--;
 #endif
   context_map_.erase(context);
 }
 
 #if DCHECK_IS_ON()
 void DatabaseManager::DidConstructDatabaseContext() {
   database_context_instance_count_++;
 }
 
 void DatabaseManager::DidDestructDatabaseContext() {
   database_context_instance_count_--;
-  ASSERT(database_context_registered_count_ <=
-         database_context_instance_count_);
+  DCHECK_LE(database_context_registered_count_,
+            database_context_instance_count_);
 }
 #endif
 
 void DatabaseManager::ThrowExceptionForDatabaseError(
     DatabaseError error,
     const String& error_message,
     ExceptionState& exception_state) {
   switch (error) {
     case DatabaseError::kNone:
       return;
     case DatabaseError::kGenericSecurityError:
       exception_state.ThrowSecurityError(error_message);
       return;
     case DatabaseError::kInvalidDatabaseState:
       exception_state.ThrowDOMException(kInvalidStateError, error_message);
       return;
     default:
-      ASSERT_NOT_REACHED();
+      NOTREACHED();
   }
 }
 
 static void LogOpenDatabaseError(ExecutionContext* context,
                                  const String& name) {
   STORAGE_DVLOG(1) << "Database " << name << " for origin "
                    << context->GetSecurityOrigin()->ToString()
                    << " not allowed to be established";
 }
 
 Database* DatabaseManager::OpenDatabaseInternal(
     ExecutionContext* context,
     const String& name,
     const String& expected_version,
     const String& display_name,
     unsigned estimated_size,
     bool set_version_in_new_database,
     DatabaseError& error,
     String& error_message) {
-  ASSERT(error == DatabaseError::kNone);
+  DCHECK_EQ(error, DatabaseError::kNone);
 
   DatabaseContext* backend_context = DatabaseContextFor(context)->Backend();
   if (DatabaseTracker::Tracker().CanEstablishDatabase(
           backend_context, name, display_name, estimated_size, error)) {
     Database* backend = new Database(backend_context, name, expected_version,
                                      display_name, estimated_size);
     if (backend->OpenAndVerifyVersion(set_version_in_new_database, error,
                                       error_message))
       return backend;
   }
 
-  ASSERT(error != DatabaseError::kNone);
+  DCHECK_NE(error, DatabaseError::kNone);
   switch (error) {
     case DatabaseError::kGenericSecurityError:
       LogOpenDatabaseError(context, name);
       return nullptr;
 
     case DatabaseError::kInvalidDatabaseState:
       LogErrorMessage(context, error_message);
       return nullptr;
 
     default:
-      ASSERT_NOT_REACHED();
+      NOTREACHED();
   }
   return nullptr;
 }
 
 Database* DatabaseManager::OpenDatabase(ExecutionContext* context,
                                         const String& name,
                                         const String& expected_version,
                                         const String& display_name,
                                         unsigned estimated_size,
                                         DatabaseCallback* creation_callback,
                                         DatabaseError& error,
                                         String& error_message) {
-  ASSERT(error == DatabaseError::kNone);
+  DCHECK_EQ(error, DatabaseError::kNone);
 
   bool set_version_in_new_database = !creation_callback;
   Database* database = OpenDatabaseInternal(
       context, name, expected_version, display_name, estimated_size,
       set_version_in_new_database, error, error_message);
   if (!database)
     return nullptr;
 
   DatabaseContextFor(context)->SetHasOpenDatabases();
   DatabaseClient::From(context)->DidOpenDatabase(
       database, context->GetSecurityOrigin()->Host(), name, expected_version);
 
   if (database->IsNew() && creation_callback) {
     STORAGE_DVLOG(1) << "Scheduling DatabaseCreationCallbackTask for database "
                      << database;
     probe::AsyncTaskScheduled(database->GetExecutionContext(), "openDatabase",
                               creation_callback);
     TaskRunnerHelper::Get(TaskType::kDatabaseAccess,
                           database->GetExecutionContext())
         ->PostTask(BLINK_FROM_HERE, WTF::Bind(&DatabaseCallbackHandleEvent,
                                               WrapPersistent(creation_callback),
                                               WrapPersistent(database)));
   }
 
-  ASSERT(database);
+  DCHECK(database);
   return database;
 }
 
 String DatabaseManager::FullPathForDatabase(SecurityOrigin* origin,
                                             const String& name,
                                             bool create_if_does_not_exist) {
   return DatabaseTracker::Tracker().FullPathForDatabase(
       origin, name, create_if_does_not_exist);
 }
 
 void DatabaseManager::LogErrorMessage(ExecutionContext* context,
                                       const String& message) {
   context->AddConsoleMessage(ConsoleMessage::Create(
       kStorageMessageSource, kErrorMessageLevel, message));
 }
 
 }  // namespace blink